fix Rectangle and Circle classes

LCluber · LCluber · commit e2fc505ded92 · 2021-05-15T20:14:00.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,8 @@
-Version 3.0.0-beta.3 (May 15th 2021)
+Version 3.0.0-beta.4 (May 15th 2021)
+-----------------------------
+ * fix Rectangle and Circle classes 
+
+Version 3.0.0-beta.3 (May 14th 2021)
 -----------------------------
  * setFromScalar(), setFromArray(), setFromRadian() and setFromDegree() methods from Vector2 class becomes setScalar(), setArray(), setRadian() and setDegree()
  * setFromScalar(), setFromArray() methods from Vector3 class becomes setScalar(), setArray()
diff --git a/dist/type6.cjs.js b/dist/type6.cjs.js
@@ -644,7 +644,7 @@ class Circle {
         return this;
     }
     setPosition(positionX, positionY) {
-        this.position.setFromScalar(positionX, positionY);
+        this.position.setScalar(positionX, positionY);
         return this;
     }
     setRadius(radius) {
@@ -697,11 +697,11 @@ class Rectangle {
         return this;
     }
     setPosition(positionX, positionY) {
-        this.position.setFromScalar(positionX, positionY);
+        this.position.setScalar(positionX, positionY);
         this.setCorners();
     }
     setSize(width, height) {
-        this.size.setFromScalar(width, height);
+        this.size.setScalar(width, height);
         this.setHalfSize();
         this.setCorners();
     }
@@ -737,7 +737,7 @@ class Vector3 extends Vector {
         this.x = 0.0;
         this.y = 0.0;
         this.z = 0.0;
-        this.setFromScalar(x, y, z);
+        this.setScalar(x, y, z);
     }
     clone() {
         return new Vector3(this.x, this.y, this.z);
diff --git a/dist/type6.iife.js b/dist/type6.iife.js
@@ -960,7 +960,7 @@ var Type6 = (function (exports) {
     }, {
       key: "setPosition",
       value: function setPosition(positionX, positionY) {
-        this.position.setFromScalar(positionX, positionY);
+        this.position.setScalar(positionX, positionY);
         return this;
       }
     }, {
@@ -1037,13 +1037,13 @@ var Type6 = (function (exports) {
     }, {
       key: "setPosition",
       value: function setPosition(positionX, positionY) {
-        this.position.setFromScalar(positionX, positionY);
+        this.position.setScalar(positionX, positionY);
         this.setCorners();
       }
     }, {
       key: "setSize",
       value: function setSize(width, height) {
-        this.size.setFromScalar(width, height);
+        this.size.setScalar(width, height);
         this.setHalfSize();
         this.setCorners();
       }
@@ -1100,7 +1100,7 @@ var Type6 = (function (exports) {
       _this.y = 0.0;
       _this.z = 0.0;
 
-      _this.setFromScalar(x, y, z);
+      _this.setScalar(x, y, z);
 
       return _this;
     }
diff --git a/dist/type6.iife.min.js b/dist/type6.iife.min.js
diff --git a/dist/type6.js b/dist/type6.js
@@ -640,7 +640,7 @@ class Circle {
         return this;
     }
     setPosition(positionX, positionY) {
-        this.position.setFromScalar(positionX, positionY);
+        this.position.setScalar(positionX, positionY);
         return this;
     }
     setRadius(radius) {
@@ -693,11 +693,11 @@ class Rectangle {
         return this;
     }
     setPosition(positionX, positionY) {
-        this.position.setFromScalar(positionX, positionY);
+        this.position.setScalar(positionX, positionY);
         this.setCorners();
     }
     setSize(width, height) {
-        this.size.setFromScalar(width, height);
+        this.size.setScalar(width, height);
         this.setHalfSize();
         this.setCorners();
     }
@@ -733,7 +733,7 @@ class Vector3 extends Vector {
         this.x = 0.0;
         this.y = 0.0;
         this.z = 0.0;
-        this.setFromScalar(x, y, z);
+        this.setScalar(x, y, z);
     }
     clone() {
         return new Vector3(this.x, this.y, this.z);
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lcluber/type6js",
-  "version": "3.0.0-beta.3",
+  "version": "3.0.0-beta.4",
   "description": "Mathematics library for Javascript",
   "keywords": [
     "maths",
diff --git a/src/geometry/circle.ts b/src/geometry/circle.ts
@@ -44,7 +44,7 @@ export class Circle {
   }
 
   public setPosition( positionX: number, positionY: number ) {
-    this.position.setFromScalar(positionX, positionY);
+    this.position.setScalar(positionX, positionY);
     return this;
   }
 
diff --git a/src/geometry/rectangle.ts b/src/geometry/rectangle.ts
@@ -32,12 +32,12 @@ export class Rectangle {
   }
   
   public setPosition(positionX: number, positionY: number): void {
-    this.position.setFromScalar( positionX, positionY );
+    this.position.setScalar( positionX, positionY );
     this.setCorners();
   }
 
   public setSize(width: number, height: number): void {
-    this.size.setFromScalar(width, height);
+    this.size.setScalar(width, height);
     this.setHalfSize();
     this.setCorners();
   }
diff --git a/src/vectors/vector3.ts b/src/vectors/vector3.ts
@@ -7,7 +7,7 @@ export class Vector3 extends Vector {
 
   constructor(x?: number, y?: number, z?: number) {
     super();
-    this.setFromScalar(x, y, z);
+    this.setScalar(x, y, z);
   }
 
   public clone(): Vector3 {

Original file line number	Diff line number	Diff line change
`@@ -644,7 +644,7 @@ class Circle {`
`644`	`644`	`return this;`
`645`	`645`	`}`
`646`	`646`	`setPosition(positionX, positionY) {`
`647`		`- this.position.setFromScalar(positionX, positionY);`
	`647`	`+ this.position.setScalar(positionX, positionY);`
`648`	`648`	`return this;`
`649`	`649`	`}`
`650`	`650`	`setRadius(radius) {`
`@@ -697,11 +697,11 @@ class Rectangle {`
`697`	`697`	`return this;`
`698`	`698`	`}`
`699`	`699`	`setPosition(positionX, positionY) {`
`700`		`- this.position.setFromScalar(positionX, positionY);`
	`700`	`+ this.position.setScalar(positionX, positionY);`
`701`	`701`	`this.setCorners();`
`702`	`702`	`}`
`703`	`703`	`setSize(width, height) {`
`704`		`- this.size.setFromScalar(width, height);`
	`704`	`+ this.size.setScalar(width, height);`
`705`	`705`	`this.setHalfSize();`
`706`	`706`	`this.setCorners();`
`707`	`707`	`}`
`@@ -737,7 +737,7 @@ class Vector3 extends Vector {`
`737`	`737`	`this.x = 0.0;`
`738`	`738`	`this.y = 0.0;`
`739`	`739`	`this.z = 0.0;`
`740`		`- this.setFromScalar(x, y, z);`
	`740`	`+ this.setScalar(x, y, z);`
`741`	`741`	`}`
`742`	`742`	`clone() {`
`743`	`743`	`return new Vector3(this.x, this.y, this.z);`
Original file line number	Diff line number	Diff line change
`@@ -640,7 +640,7 @@ class Circle {`
`640`	`640`	`return this;`
`641`	`641`	`}`
`642`	`642`	`setPosition(positionX, positionY) {`
`643`		`- this.position.setFromScalar(positionX, positionY);`
	`643`	`+ this.position.setScalar(positionX, positionY);`
`644`	`644`	`return this;`
`645`	`645`	`}`
`646`	`646`	`setRadius(radius) {`
`@@ -693,11 +693,11 @@ class Rectangle {`
`693`	`693`	`return this;`
`694`	`694`	`}`
`695`	`695`	`setPosition(positionX, positionY) {`
`696`		`- this.position.setFromScalar(positionX, positionY);`
	`696`	`+ this.position.setScalar(positionX, positionY);`
`697`	`697`	`this.setCorners();`
`698`	`698`	`}`
`699`	`699`	`setSize(width, height) {`
`700`		`- this.size.setFromScalar(width, height);`
	`700`	`+ this.size.setScalar(width, height);`
`701`	`701`	`this.setHalfSize();`
`702`	`702`	`this.setCorners();`
`703`	`703`	`}`
`@@ -733,7 +733,7 @@ class Vector3 extends Vector {`
`733`	`733`	`this.x = 0.0;`
`734`	`734`	`this.y = 0.0;`
`735`	`735`	`this.z = 0.0;`
`736`		`- this.setFromScalar(x, y, z);`
	`736`	`+ this.setScalar(x, y, z);`
`737`	`737`	`}`
`738`	`738`	`clone() {`
`739`	`739`	`return new Vector3(this.x, this.y, this.z);`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@lcluber/type6js",`
`3`		`- "version": "3.0.0-beta.3",`
	`3`	`+ "version": "3.0.0-beta.4",`
`4`	`4`	`"description": "Mathematics library for Javascript",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"maths",`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export class Circle {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`public setPosition( positionX: number, positionY: number ) {`
`47`		`- this.position.setFromScalar(positionX, positionY);`
	`47`	`+ this.position.setScalar(positionX, positionY);`
`48`	`48`	`return this;`
`49`	`49`	`}`
`50`	`50`
Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,12 @@ export class Rectangle {`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`public setPosition(positionX: number, positionY: number): void {`
`35`		`- this.position.setFromScalar( positionX, positionY );`
	`35`	`+ this.position.setScalar( positionX, positionY );`
`36`	`36`	`this.setCorners();`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`public setSize(width: number, height: number): void {`
`40`		`- this.size.setFromScalar(width, height);`
	`40`	`+ this.size.setScalar(width, height);`
`41`	`41`	`this.setHalfSize();`
`42`	`42`	`this.setCorners();`
`43`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ export class Vector3 extends Vector {`
`7`	`7`
`8`	`8`	`constructor(x?: number, y?: number, z?: number) {`
`9`	`9`	`super();`
`10`		`- this.setFromScalar(x, y, z);`
	`10`	`+ this.setScalar(x, y, z);`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`public clone(): Vector3 {`