Merge branch 'develop'

NgoKimPhu · NgoKimPhu · commit f185d6fe1f56 · 2023-11-08T22:15:49.000+07:00
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -0,0 +1,7 @@
+version: 2
+updates:
+  # Maintain dependencies for GitHub Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -16,6 +16,9 @@ on:
         type: string
         required: true
 
+env:
+  IMAGE_REGISTRY: asia.gcr.io
+
 jobs:
   build:
     runs-on: self-hosted
@@ -25,7 +28,7 @@ jobs:
       - name: prepare
         id: prepare
         env:
-          IMAGE_REPOSITORY: asia.gcr.io/kyber-operation/${{ inputs.cluster }}/${{ inputs.service }}
+          IMAGE_REPOSITORY: ${{ env.IMAGE_REGISTRY }}/kyber-operation/${{ inputs.cluster }}/${{ inputs.service }}
         run: |
           #!/bin/bash
           BRANCH_NAME=$(echo ${GITHUB_REF#refs/heads/})
@@ -38,11 +41,6 @@ jobs:
         with:
           credentials_json: "${{ secrets.GCR_CREDENTIALS }}"
       - uses: google-github-actions/setup-gcloud@v1
-      - name: Cache Docker layers
-        uses: actions/cache@v3
-        with:
-          path: /tmp/.buildx-cache
-          key: ${{ runner.os }}-${{ inputs.service }}-buildx
       - uses: docker/build-push-action@v5
         with:
           context: .
@@ -61,9 +59,5 @@ jobs:
             ${{ steps.prepare.outputs.image_url }}
           secrets: |
             "gh_pat=${{ secrets.GH_PAT }}"
-          cache-from: type=local,src=/tmp/.buildx-cache
-          cache-to: type=local,dest=/tmp/.buildx-cache-new
-      - name: Move Docker cache
-        run: |
-          rm -rf /tmp/.buildx-cache
-          mv /tmp/.buildx-cache-new /tmp/.buildx-cache
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -5,6 +5,10 @@ name: CI
 # concurrency:
 #   group: ci-workflow-${{ github.ref }}-${{ github.event_name }}
 #   cancel-in-progress: true
+# Sample permissions config:
+# permissions:
+#   issues: write
+#   pull-requests: write
 
 on:
   workflow_call:
@@ -19,6 +23,7 @@ jobs:
       - uses: actions/setup-go@v4
         with:
           go-version-file: 'go.mod'
+          cache: false
 
       - uses: golangci/golangci-lint-action@v3
         with:
@@ -27,6 +32,8 @@ jobs:
 
   test:
     runs-on: self-hosted
+    outputs:
+      cov: ${{ steps.cov.outputs.cov }}
     steps:
       - name: Add git config for Go private module
         run: git config --global url."https://${{ secrets.GH_PAT }}:x-oauth-basic@github.com/".insteadOf https://github.com/
@@ -36,7 +43,84 @@ jobs:
           go-version-file: 'go.mod'
 
       - name: Run tests
-        run: go test -race -coverprofile cover.out -vet=off ./...
-      - name: Print coverage
         run: |
-          go tool cover -func cover.out | grep total | awk '{notice="Statement Coverage: " substr($3, 1, length($3))} END {print notice}'
+          go test -race -cover -vet=off ./... >cover.out || EC=$?;
+            { echo '```'; cat cover.out; } | tee -a $GITHUB_STEP_SUMMARY; (exit $EC)
+      - id: cov
+        name: Get coverage
+        run: |
+          {
+            echo 'cov<<EOF'
+            <cover.out grep -v 'no test files' |
+              awk '{printf "%s b %.2f\n", $2, $5}'
+            echo 'EOF'
+          } >> $GITHUB_OUTPUT
+
+  test_base:
+    runs-on: self-hosted
+    if: github.event_name == 'pull_request'
+    outputs:
+      cov: ${{ steps.cov.outputs.cov }}
+    steps:
+      - name: Add git config for Go private module
+        run: git config --global url."https://${{ secrets.GH_PAT }}:x-oauth-basic@github.com/".insteadOf https://github.com/
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.base.ref }}
+      - uses: actions/setup-go@v4
+        with:
+          go-version-file: 'go.mod'
+
+      - id: cov
+        name: Get coverage
+        run: |
+          echo '```' >> $GITHUB_STEP_SUMMARY
+          {
+            echo 'cov<<EOF'
+            go test -covermode=set -vet=off ./... |
+              tee -a $GITHUB_STEP_SUMMARY |
+              grep -v 'no test files' |
+              awk '{printf "%s a %.2f\n", $2, $5}'
+            echo 'EOF'
+          } >> $GITHUB_OUTPUT
+
+  test_coverage:
+    runs-on: self-hosted
+    needs: [test, test_base]
+    if: github.event_name == 'pull_request' && !cancelled() && needs.test.result == 'success'
+    steps:
+      - id: cov
+        name: Generate coverage report
+        run: |
+          {
+            echo 'report<<EOF'
+            <<<"${{ needs.test_base.outputs.cov }}"$'\n'"${{ needs.test.outputs.cov }}" sort |
+              awk 'function diff(a, b) {
+                  if (!a && !b) { return }
+                  printf("| %s | %.2f%% | %.2f%% | %s |\n", pkg, a, b, (a && b < a) ? ":x:" : ":heavy_check_mark:")
+                }
+
+                BEGIN { print("Test coverage changes:\n" \
+                  "| Package | Before | After | Diff |\n" \
+                  "| ------- | -----: | ----: | ---- |")
+                }
+
+                $1 != pkg {
+                  diff(a, b)
+                  a = b = ""
+                  pkg = $1
+                }
+                $2 == "a" { a = $3 }
+                $2 == "b" { b = $3 }
+
+                END {
+                  diff(a, b)
+                }' | tee -a $GITHUB_STEP_SUMMARY
+            echo 'EOF'
+          } >> $GITHUB_OUTPUT
+      - name: Comment PR
+        uses: thollander/actions-comment-pull-request@v2
+        with:
+          pr_number: ${{ github.event.pull_request.number }}
+          comment_tag: cov
+          message: ${{ steps.cov.outputs.report }}
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -21,6 +21,9 @@ on:
         type: string
         required: true
 
+env:
+  IMAGE_REGISTRY: asia.gcr.io
+
 jobs:
   release:
     runs-on: self-hosted
@@ -29,7 +32,7 @@ jobs:
       - name: prepare
         id: prepare
         env:
-          IMAGE_REPOSITORY: asia.gcr.io/kyber-operation/${{ inputs.cluster }}/${{ inputs.service }}
+          IMAGE_REPOSITORY: ${{ env.IMAGE_REGISTRY }}/kyber-operation/${{ inputs.cluster }}/${{ inputs.service }}
           INPUT_TAG: ${{ github.event.inputs.version }}
         run: |
           #!/bin/bash
@@ -40,13 +43,8 @@ jobs:
       - uses: docker/setup-buildx-action@v3
       - uses: google-github-actions/auth@v1
         with:
-          credentials_json: '${{ secrets.GCR_CREDENTIALS }}'
+          credentials_json: "${{ secrets.GCR_CREDENTIALS }}"
       - uses: google-github-actions/setup-gcloud@v1
-      - name: Cache Docker layers
-        uses: actions/cache@v3
-        with:
-          path: /tmp/.buildx-cache
-          key: ${{ runner.os }}-${{ inputs.service }}-buildx
       - uses: docker/build-push-action@v5
         with:
           context: .
@@ -66,12 +64,8 @@ jobs:
             ${{ steps.prepare.outputs.image_repository }}:${{ steps.prepare.outputs.version_tag }}
           secrets: |
             "gh_pat=${{ secrets.GH_PAT }}"
-          cache-from: type=local,src=/tmp/.buildx-cache
-          cache-to: type=local,dest=/tmp/.buildx-cache-new
-      - name: Move Docker cache
-        run: |
-          rm -rf /tmp/.buildx-cache
-          mv /tmp/.buildx-cache-new /tmp/.buildx-cache
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
       - name: Create tag
         env:
           VERSION_TAG: ${{ steps.prepare.outputs.version_tag }}
