-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Labels
enhancementkind/enhancementNew feature or requestNew feature or requestparticipation/good first issueGood for newcomersGood for newcomers
Description
A new gRPC method was introduced in #439
service RateLimitService {
// The report method modifies specific counters associated with the descriptors, incrementing each one by the amount specified in $hits_addend$
rpc Report(envoy.service.ratelimit.v3.RateLimitRequest) returns (envoy.service.ratelimit.v3.RateLimitResponse);
}
Should we add custom metrics (i.e. report_calls
) for the new gRPC service method? Currently we have (relevant ones):
# HELP authorized_calls Authorized calls
# TYPE authorized_calls counter
authorized_calls{limitador_namespace="test_namespace"} 19
# HELP limited_calls Limited calls
# TYPE limited_calls counter
limited_calls{limitador_namespace="test_namespace"} 1
Metadata
Metadata
Assignees
Labels
enhancementkind/enhancementNew feature or requestNew feature or requestparticipation/good first issueGood for newcomersGood for newcomers
Type
Projects
Status
No status