Drag and Drop

[duskfallcrew]

What's Changed

Pull Request: Major Parsing, Stability, and UI Enhancements (vX.Y.Z?)

This significant update addresses numerous underlying issues, enhances metadata parsing capabilities, and introduces new UI features for a more robust and user-friendly experience.

(Optional: Link to any relevant issues this PR closes, e.g., "Closes #12, Closes #15")

---

Core Stability & Bug Fixes:

• Resolved critical import errors and ModuleNotFoundErrors related to vendored package structure (vendored_sdpr, format sub-package, utility.py, constants.py).
• Fixed NameError for INITIAL_LOG_LEVEL_FROM_INIT by ensuring correct_types.py directly imports LOG_LEVEL from the package root.
• Corrected AttributeError: 'str' object has no attribute 'value' by refactoring EmptyField, UpField, and DownField in correct_types.py to be proper enum.Enum classes. UI and metadata parser now correctly use .value and get_ordered_labels().
• Fixed AttributeError in widgets.py by using correct ExtensionType attribute names (e.g., SCHEMA_FILES, MODEL_FILES, PLAIN_TEXT_LIKE).
• Resolved TypeError for A1111.__init__() calls in ImageDataReader by removing unexpected width/height arguments, aligning with parser's actual signature.
• Fixed ValueError: not enough values to unpack in A1111._sd_format() by correcting regex match unpacking.
• Addressed NameError: name 'Path' is not defined in ImageDataReader by adding from pathlib import Path.

Vendored SD-Prompt-Reader Enhancements:

• Refactored ImageDataReader._try_parser() helper for clearer instantiation and status checking of format parsers.
• Ensured ImageDataReader.status is correctly updated based on the success/failure of individual format parsers, fixing misleading FORMAT_ERROR reports.
• Improved status setting within individual format parsers (e.g., A1111._process() now robustly sets its own success/failure status).
• Standardized logger names within the vendored_sdpr components to use the "DSVendored_SDPR" prefix for consistent log handling.
• Pruned vendored_sdpr/format/utility.py to retain only core string/data manipulation functions relevant to backend parsing, removing GUI-specific dependencies.

New Features & Parser Additions:

• Implemented Drag and Drop support: Users can now drag and drop image files or folders directly onto the main application window for easier and faster loading. The dropped file (if a file is dropped) will be auto-selected in the list.
• Added RuinedFooocusFormat parser: Enables parsing of metadata from images generated by RuinedFooocus, extracting prompts and key generation parameters from its specific JSON structure.
• Added CivitaiComfyUIFormat parser: Provides support for parsing Civitai's ComfyUI-based UserComment metadata, including handling potential mojibake and extracting parameters from the "extraMetadata" field.
• Integrated GGUFParser: Basic metadata extraction from GGUF model files is now supported via model_parsers.
• All new parsers are integrated into their respective import paths and processing chains.

Logging Improvements:

• Fixed warning in main.py regarding logger reconfiguration by aligning the function call (reconfigure_all_loggers) with the definition in logger.py. Command-line log level setting is now fully effective.
• Added more detailed debug logging throughout ImageDataReader, A1111 parser, and widgets.py to aid in future diagnostics.

UI & CorrectTypes Refinements:

• BaseFormat.py (vendored) updated with an expanded PARAMETER_KEY list and improved parse() method for better error handling and status reporting by subclasses.
• correct_types.py now correctly defines Enums for UI field mapping and provides get_ordered_labels() methods, ensuring type safety and clarity.
• ui.py updated to correctly use these Enum methods and .value access for dictionary keys and UI section iteration.

---

(Optional: Add any testing notes or specific areas for reviewers to focus on)
Testing Done:

• Tested with A1111/Forge PNGs, showing correct parsing and status.
• Tested with Civitai ComfyUI JPGs, showing correct parsing by CivitaiComfyUIFormat.
• Drag and drop functionality tested for files and folders.
• (Add any other specific tests you performed)

Areas for Review:

• Verification of __init__ signatures for NovelAI(info=...) and ComfyUI(info=...) calls within ImageDataReader.py (regarding width/height arguments).
• Robustness of the regex in make_paired_str_dict for diverse A1111 settings strings.

---

This PR aims to significantly improve the application's reliability and extend its parsing capabilities.

• Refactor: Major improvements to parsing, stability, and UI by @duskfallcrew in Refactor: Major improvements to parsing, stability, and UI #83

Full Changelog: 0.58.1...0.58.2

---

This discussion was created from the release Drag and Drop.