Skip to content

Commit 84472a6

Browse files
authored
YomiCalculator - add default constructor to avoid warnings on recent JDKs
- add default constructor to avoid warnings on recent JDKs - Minor whitespace and documentation changes
1 parent da7f3b7 commit 84472a6

File tree

1 file changed

+29
-21
lines changed

1 file changed

+29
-21
lines changed

src/main/java/com/kosherjava/zmanim/hebrewcalendar/YomiCalculator.java

Lines changed: 29 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* Zmanim Java API
3-
* Copyright (C) 2011-2020 Eliyahu Hershfeld
3+
* Copyright (C) 2011-2025 Eliyahu Hershfeld
44
*
55
* This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General
66
* Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option)
@@ -23,7 +23,7 @@
2323
* use the {@link YerushalmiYomiCalculator}. The library may cover Mishna Yomi etc. at some point in the future.
2424
*
2525
* @author © Bob Newell (original C code)
26-
* @author © Eliyahu Hershfeld 2011 - 2020
26+
* @author © Eliyahu Hershfeld 2011 - 2025
2727
*/
2828
public class YomiCalculator {
2929

@@ -43,6 +43,13 @@ public class YomiCalculator {
4343
* @see #getDafYomiBavli(JewishCalendar) for details.
4444
*/
4545
private static final int shekalimJulianChangeDay = getJulianDay(shekalimChangeDay);
46+
47+
/**
48+
* Default constructor.
49+
*/
50+
public YomiCalculator() {
51+
// nothing here
52+
}
4653

4754
/**
4855
* Returns the <a href="http://en.wikipedia.org/wiki/Daf_yomi">Daf Yomi</a> <a
@@ -52,7 +59,7 @@ public class YomiCalculator {
5259
* that a change in length of the cycle was instituted starting in the eighth Daf Yomi cycle beginning on June 24,
5360
* 1975. The Daf Yomi Bavli cycle has a single masechta of the Talmud Yerushalmi - Shekalim as part of the cycle.
5461
* Unlike the Bavli where the number of daf per masechta was standardized since the original <a
55-
* href="http://en.wikipedia.org/wiki/Daniel_Bomberg">Bomberg Edition</a> published from 1520 to 1523, there is no
62+
* href="http://en.wikipedia.org/wiki/Daniel_Bomberg">Bomberg Edition</a> published from 1520 - 1523, there is no
5663
* uniform page length in the Yerushalmi. The early cycles had the Yerushalmi Shekalim length of 13 days following the
5764
* <a href=
5865
* "https://he.wikipedia.org/wiki/%D7%93%D7%A4%D7%95%D7%A1_%D7%A1%D7%9C%D7%90%D7%95%D7%95%D7%99%D7%98%D7%90">Slavuta/Zhytomyr</a>
@@ -66,7 +73,7 @@ public class YomiCalculator {
6673
* @return the {@link Daf}.
6774
*
6875
* @throws IllegalArgumentException
69-
* if the date is prior to the September 11, 1923, start date of the first Daf Yomi cycle
76+
* if the date is prior to the September 11, 1923, the start date of the first Daf Yomi cycle.
7077
*/
7178
public static Daf getDafYomiBavli(JewishCalendar jewishCalendar) {
7279
/*
@@ -103,24 +110,25 @@ public static Daf getDafYomiBavli(JewishCalendar jewishCalendar) {
103110
if (cycleNo <= 7) {
104111
blattPerMasechta[4] = 13;
105112
}
113+
106114
// Finally find the daf.
107-
for (int i : blattPerMasechta) {
108-
masechta++;
109-
total = total + i - 1;
110-
if (dafNo < total) {
111-
blatt = 1 + i - (total - dafNo);
112-
// Fiddle with the weird ones near the end.
113-
if (masechta == 36) {
114-
blatt += 21;
115-
} else if (masechta == 37) {
116-
blatt += 24;
117-
} else if (masechta == 38) {
118-
blatt += 32;
119-
}
120-
dafYomi = new Daf(masechta, blatt);
121-
break;
122-
}
123-
}
115+
for (int i : blattPerMasechta) {
116+
masechta++;
117+
total = total + i - 1;
118+
if (dafNo < total) {
119+
blatt = 1 + i - (total - dafNo);
120+
// Fiddle with the weird ones near the end.
121+
if (masechta == 36) {
122+
blatt += 21;
123+
} else if (masechta == 37) {
124+
blatt += 24;
125+
} else if (masechta == 38) {
126+
blatt += 32;
127+
}
128+
dafYomi = new Daf(masechta, blatt);
129+
break;
130+
}
131+
}
124132

125133
return dafYomi;
126134
}

0 commit comments

Comments
 (0)