Skip to content

Commit 59bda96

Browse files
authored
Rollup merge of #143329 - folkertdev:minicore-diagnostic-on-unimplemented, r=jieyouxu
minicore: use core's `diagnostic::on_unimplemented` messages Without these attributes, the error message is different. Keeping the diagnostics up-to-date seems related to rust-lang/rust#137531. The modified test files are reported in rust-lang/rust#143319 as failing for `--target=riscv64gc-unknown-linux-gnu`. Using `minicore` for them makes it easier to troubleshoot this sort of issue. r? ``@jieyouxu``
2 parents f2510d4 + 8c8c510 commit 59bda96

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/tests/minicore.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,12 @@ If you find a `core` item to be missing from the [`minicore`] stub, consider
3939
adding it to the test auxiliary if it's likely to be used or is already needed
4040
by more than one test.
4141

42+
## Staying in sync with `core`
43+
44+
The `minicore` items must be kept up to date with `core`. For consistent
45+
diagnostic output between using `core` and `minicore`, any `diagnostic`
46+
attributes (e.g. `on_unimplemented`) should be replicated exactly in `minicore`.
47+
4248
## Example codegen test that uses `minicore`
4349

4450
```rust,no_run

0 commit comments

Comments
 (0)