JSON save error when using custom port

[wildporg]

Describe the bug
When connecting to a server with a custom port, the json file does not save because the filename contains a colon

To Reproduce
Steps to reproduce the behavior:
Run an instance with a custom port, e.g. :
./OpenDirectoryDownloader -u "http://185.203.56.37:2096/" -j

Expected behavior

[ERR] Error saving session to JSON System.UnauthorizedAccessException: Access to the path '/home/pi/Scans/http:__185.203.56.37:2096_.json' is denied. ---> System.IO.IOException: Permission denied --- End of inner exception stack trace --- at Interop.ThrowExceptionForIoErrno(ErrorInfo, String, Boolean) at Interop.CheckIo(Error, String , Boolean ) at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String, OpenFlags, Int32, Func`4) at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String, FileMode, FileAccess, FileShare, FileOptions, Int64, UnixFileMode, Int64& , UnixFileMode& , Func`4 ) at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String, FileMode, FileAccess, FileShare, FileOptions, Int64, Nullable`1 , Func`4 ) at System.IO.Strategies.OSFileStreamStrategy..ctor(String, FileMode, FileAccess, FileShare, FileOptions, Int64, Nullable`1) at System.IO.Strategies.UnixFileStreamStrategy..ctor(String, FileMode, FileAccess, FileShare, FileOptions, Int64, Nullable`1) at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String, FileMode, FileAccess, FileShare, FileOptions, Int64, Nullable`1) at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream, String, FileMode, FileAccess, FileShare, Int32, FileOptions, Int64, Nullable`1) at System.IO.FileStream..ctor(String, FileMode, FileAccess, FileShare, Int32, FileOptions, Int64) at System.IO.FileStream..ctor(String, FileMode, FileAccess, FileShare, Int32, FileOptions) at System.IO.FileStream..ctor(String, FileMode, FileAccess, FileShare, Int32, Boolean) at System.IO.FileStream..ctor(String, FileMode, FileAccess, FileShare, Int32) at System.IO.StreamWriter.ValidateArgsAndOpenPath(String, Boolean, Encoding, Int32) at System.IO.StreamWriter..ctor(String, Boolean, Encoding, Int32) at System.IO.StreamWriter..ctor(String) at OpenDirectoryDownloader.Library.SaveSessionJson(Session session, String filePath) at OpenDirectoryDownloader.OpenDirectoryIndexer.<>c__DisplayClass71_0.<b__0>d.MoveNext()

Desktop:

• OS: Raspbian
• Version: Debian GNU/Linux 11 (bullseye) 64Bit

[KoalaBear84]

Oh, why did I reply so late again! 😅

Hmm, this is strange, as the invalid chars are stripped/replaced with underscores. So it looks like that isn't working for this flavor or unix. Which is strange because the list is provided by .NET itself.

Need to find a way to reproduce it over here, hope to do that soon.

[KoalaBear84]

I've tried reproducing this, but it works 😅

koalabear@DESKTOP-XXX:~$ ./OpenDirectoryDownloader --json --url "http://81.4.126.139:9090/Duke.Nukem.3D.Atomic.Edition-GOG/Goodies/"
Started with PID 6110
URL specified: http://81.4.126.139:9090/Duke.Nukem.3D.Atomic.Edition-GOG/Goodies/
Started indexing!
┌─────────────────────────────────────────────────────────────────────────┐
│ KoalaBear84/OpenDirectoryDownloader v3.3.0.4                            │
├─────────────────────────────────────────────────────────────────────────┤
│ Press I for info (this)                                                 │
│ Press S for statistics                                                  │
│ Press T for thread info                                                 │
│ Press U for Save TXT                                                    │
│ Press J for Save JSON                                                   │
├─────────────────────────────────────────────────────────────────────────┤
│ Press ESC or X to EXIT                                                  │
└─────────────────────────────────────────────────────────────────────────┘

Finshed indexing
***
Saving session to JSON..
Saved session: /home/koalabear/Scans/http:__81.4.126.139:9090_Duke.Nukem.3D.Atomic.Edition-GOG_Goodies_.json
Finished indexing!
Press ESC to exit! Or C to copy to clipboard and quit!

koalabear@DESKTOP-XXX:~$ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Could it be that 'you' are not allowed to create a new folder (in the pi) folder?