Signals

[franklinvp]

The method Multiprocess.handle_signals calls other methods which names are built from the signal name. The class Multiprocess does not define handlers for all the signals.

Question 1: Is the intention of the implementation of Multiprocess.handle_signals that users would monkey patch the Multiprocess class to add their own signal handlers?

Question 2: Can we expect some signals, for example SIGUSR1, to remain unused for something specific in uvicorn such that if monkey patched we don't affect other future functionality of uvicorn? For example, gunicorn uses SIGUSR1 to make the workers reopen the log files.

[franklinvp]

@abersheeran , since you added Multiprocesss.handle_signals, probably you know what the intention and future plan is for the signal handling methods, in particular for the signals that do not currently have a signal handler implemented.

[abersheeran]

While writing this, I referred to some of the design of gunicorn. However, I believe that gunicorn handles too many signals, so I only kept a few of the most commonly used ones. As for other signals, in the design, users should be able to inherit and override them on their own.