Apply timeout_graceful_shutdown when hot-reloading #2609
Unanswered
jamesh1999
asked this question in
Ideas
Replies: 1 comment
-
I'll set up the MR for this. Don't think it's anything too controversial and it should be the end of all the last Windows hot-reloading issues |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
As seen in #2000, there is some uncertainty about Windows actually killing a
uvicorn
server to hot reload. I have raised #2604 which I think is useful as it is often sufficient to trigger a clean shutdown. However, I still run into issues when running the server headlessly (CI pipelines in particular).I would like to use the existing config option
--timeout-graceful-shutdown
to forcibly terminate the server if it still doesn't reload. This way there is no chance for the server to keep running indefinitely.Beta Was this translation helpful? Give feedback.
All reactions