Getting response body in Starlette middleware no longer correct #2854
Replies: 1 comment
-
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Minor issue but the types for the solution posted in this issue #874 are no longer correct after this change d771bb7 where
_StreamingResponse
now inherits fromResponse
instead ofStreamingResponse
.While that code does technically still work, in general I think it makes writing middleware more confusing as
isinstance(response, StreamingResponse)
will strangely not work as expected.Beta Was this translation helpful? Give feedback.
All reactions