Skip to content

Commit fe581ff

Browse files
franknoirotgithub-actions[bot]graphite-app[bot]
authored
Replace lower-right controls with a full status bar (#7443)
* Resurrect this branch with an initial commit * Add telemetry to global default items * Add credit progress bar to status bar * Add selection info to status bar * Add help menu to "local" side * Rename statusBarItem utils * Delete LowerRightControls, now unused * fix lints * Update snapshots * Add test-id to network health indicator, which all E2E tests rely on * Update src/components/StatusBar/StatusBar.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * Fix a couple little issues with the e2e tests * Fix gizmo e2e tests (it moved) and network health test (it should not be on home page) * More tweaks to accomodate changes to network health indicator We made use of two test ID's to make Playwright aware of the state, one of which was on the icon. Now that we want to normalize usage of the status bar along a more limited API, that became a not possible. This just tweaks some test code that relied on that fact. * Fix lints * Update snapshots * Re-run CI * Update snapshots * Update snapshots * Test fixes, label logic tweaks * Update snapshots * Update snapshots * Fix up last few tests hopefully. Relative path syntax failed on windows * Relative paths are behaving badly on Windows, use the old code here * Update snapshots * Update snapshots * Tweak y-value to work on all platforms, ubuntu didn't like 438 * Fix tooltip and popover alignment on NetworkMachineIndicator * Remove dire warning comment * Update src/components/StatusBar/defaultStatusBarItems.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * @lee-at-zoo-corp feedback, pull hooks out of UI code * Re-run CI --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
1 parent b301fbb commit fe581ff

File tree

46 files changed

+646
-388
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+646
-388
lines changed

e2e/playwright/regression-tests.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@ extrude002 = extrude(profile002, length = 150)
575575
name: 'Projects',
576576
})
577577
const projectLink = page.getByRole('link', { name: 'bracket' })
578-
const networkHealthIndicator = page.getByTestId('network-toggle')
578+
const networkHealthIndicator = page.getByTestId(/network-toggle/)
579579

580580
await test.step('Check the home page', async () => {
581581
await expect(projectsHeading).toBeVisible()

e2e/playwright/snapshot-tests.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@ test('theme persists', async ({ page, context, homePage }) => {
798798

799799
await page.getByTestId('settings-close-button').click()
800800

801-
const networkToggle = page.getByTestId('network-toggle')
801+
const networkToggle = page.getByTestId(/network-toggle/)
802802

803803
// simulate network down
804804
await u.emulateNetworkConditions({

0 commit comments

Comments
 (0)