Refactor Shell codemod to allow variable-less pipes (#7691)

* WIP: Allow all sweeps to work on variable-less profiles
Fixes #7657

* Fix test

* Fix circ dep

* Add unit tests for getVariableExprsFromSelection

* Codespell

* Add unit tests for createVariableExpressionsArray

* Add unit test createPathToNodeForLastVariable

* WIP new util function

* Add other test case

* We going

* Lint & complete addExtrude tests

* Add addSweep test

* Add basic addLoft and addRevolve tests, will have to see how to distribute coverage

* Add getSketchSelectionsFromOperation test

* retrieveSelectionsFromOpArg generic fn and tests

* Extend getVariableExprsFromSelection to include child look up

* Add test to catch potentially wrong double pipe substitutions

* Fix circular dep and test

* Fix bad imports

* WIP: Refactor Shell codemod to allow variable-less pipes

* Fix test, still need to fix circ dep

* Fix circular dep

* Remove playwright tests and beefing up vitest integration tests

* Back to a px click for loft selection :sad:, other fixes

* Leverage @jtran's magic 🙏

* Fix existing test

* Another test case

* Clean up

* Clean up

* Edit cases

* WIP pw

* Fix test

* Add todo

* Remove pw sketch on face pw tests

* Clean up

* WIP more unit tests

* Making things a bit more reliable

* Add test case for issue #7640

* Add new case when for no var no pipe

* Improve test and fix spelling

* Update snapshots

* Update snapshots

* Update snapshots

* Update snapshots

* Update snapshots

* Update snapshots

* Fix url-checker

* Remove explicit solids selection, also fixing #7669 at the same time

* Codespell

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: pierremtb

e2e/playwright/point-click.spec.ts

@@ -47,6 +47,7 @@ import type {
   ArrayExpression,
   CallExpressionKw,
   Expr,
+  ExpressionStatement,
   Literal,
   PathToNode,
   PipeExpression,
@@ -337,64 +338,6 @@ export function mutateObjExpProp(
   return false
 }
 
-export function addShell({
-  node,
-  sweepName,
-  faces,
-  thickness,
-  insertIndex,
-  variableName,
-}: {
-  node: Node<Program>
-  sweepName: string
-  faces: Expr[]
-  thickness: Expr
-  insertIndex?: number
-  variableName?: string
-}): { modifiedAst: Node<Program>; pathToNode: PathToNode } {
-  const modifiedAst = structuredClone(node)
-  const name =
-    variableName ?? findUniqueName(node, KCL_DEFAULT_CONSTANT_PREFIXES.SHELL)
-  const shell = createCallExpressionStdLibKw(
-    'shell',
-    createLocalName(sweepName),
-    [
-      createLabeledArg('faces', createArrayExpression(faces)),
-      createLabeledArg('thickness', thickness),
-    ]
-  )
-
-  const variable = createVariableDeclaration(name, shell)
-  const insertAt =
-    insertIndex !== undefined
-      ? insertIndex
-      : modifiedAst.body.length
-        ? modifiedAst.body.length
-        : 0
-
-  if (modifiedAst.body.length) {
-    modifiedAst.body.splice(insertAt, 0, variable)
-  } else {
-    modifiedAst.body.push(variable)
-  }
-
-  const argIndex = 0
-  const pathToNode: PathToNode = [
-    ['body', ''],
-    [insertAt, 'index'],
-    ['declaration', 'VariableDeclaration'],
-    ['init', 'VariableDeclarator'],
-    ['arguments', 'CallExpressionKw'],
-    [argIndex, ARG_INDEX_FIELD],
-    ['arg', LABELED_ARG_FIELD],
-  ]
-
-  return {
-    modifiedAst,
-    pathToNode,
-  }
-}
-
 export function sketchOnExtrudedFace(
   node: Node<Program>,
   sketchPathToNode: PathToNode,
@@ -1275,7 +1218,28 @@ export function setCallInAst(
       if (err(pipe)) {
         return pipe
       }
-      pipe.node.body.push(call)
+
+      if (pipe.node.type === 'PipeExpression') {
+        pipe.node.body.push(call)
+      } else if (pipe.node.type === 'CallExpressionKw') {
+        const expression = getNodeFromPath<ExpressionStatement>(
+          ast,
+          pathIfPipe,
+          'ExpressionStatement'
+        )
+        if (err(expression) || expression.node.type !== 'ExpressionStatement') {
+          return new Error('Could not retrieve ExpressionStatement')
+        }
+
+        expression.node.expression = createPipeExpression([
+          expression.node.expression,
+          call,
+        ])
+      } else {
+        return new Error(
+          'Expected pipeIfPipe to be a PipeExpression or CallExpressionKw'
+        )
+      }
       pathToNode = pathIfPipe
     } else {
       const name = findUniqueName(ast, call.callee.name.name)