More warnings

Signed-off-by: Nick Cameron <nrc@ncameron.org>

Author: nrc

rust/kcl-lib/src/execution/annotations.rs

@@ -12,7 +12,7 @@ use crate::{
 };
 
 /// Annotations which should cause re-execution if they change.
-pub(super) const SIGNIFICANT_ATTRS: [&str; 2] = [SETTINGS, NO_PRELUDE];
+pub(super) const SIGNIFICANT_ATTRS: [&str; 3] = [SETTINGS, NO_PRELUDE, WARNINGS];
 
 pub(crate) const SETTINGS: &str = "settings";
 pub(crate) const SETTINGS_UNIT_LENGTH: &str = "defaultLengthUnit";
@@ -162,7 +162,7 @@ pub(super) fn many_of(
                         vec![source_range],
                     ))
                 })
-                .map(|v| *v)
+                .copied()
         })
         .collect::<Result<Vec<&str>, KclError>>()
 }

rust/kcl-lib/src/execution/exec_ast.rs

@@ -1780,6 +1780,7 @@ impl Node<PipeExpression> {
 #[cfg(test)]
 mod test {
     use std::sync::Arc;
+
     use tokio::io::AsyncWriteExt;
 
     use super::*;

rust/kcl-lib/src/execution/mod.rs

@@ -604,8 +604,9 @@ impl ExecutorContext {
                     settings: &self.settings,
                 };
 
+                let cache_result = cache::get_changed_program(old, new).await;
                 // Get the program that actually changed from the old and new information.
-                let (clear_scene, program, import_check_info) = match cache::get_changed_program(old, new).await {
+                let (clear_scene, program, import_check_info) = match cache_result {
                     CacheResult::ReExecute {
                         clear_scene,
                         reapply_settings,

rust/kcl-lib/src/execution/types.rs

@@ -760,7 +760,7 @@ impl NumericType {
         }
     }
 
-    fn coerce(&self, val: &KclValue) -> Result<KclValue, CoercionError> {
+    fn coerce(&self, val: &KclValue, exec_state: &mut ExecState) -> Result<KclValue, CoercionError> {
         let KclValue::Number { value, ty, meta } = val else {
             return Err(val.into());
         };
@@ -832,6 +832,14 @@ impl NumericType {
             }
 
             (Default { angle: a1, .. }, Known(UnitType::Angle(a2))) => {
+                let mut source_ranges = Into::<Vec<SourceRange>>::into(val);
+                // A single source range means it's not via a function or something.
+                if source_ranges.len() == 1 {
+                    exec_state.warn(
+                        CompilationError::err(source_ranges.pop().unwrap(), "Prefer to use explicit units for angles"),
+                        annotations::WARN_ANGLE_UNITS,
+                    );
+                }
                 let (value, ty) = a1.adjust_to(*value, *a2);
                 Ok(KclValue::Number {
                     value,
@@ -1156,7 +1164,7 @@ impl KclValue {
             PrimitiveType::Any => Ok(self.clone()),
             PrimitiveType::Number(ty) => {
                 if convert_units {
-                    return ty.coerce(self);
+                    return ty.coerce(self, exec_state);
                 }
 
                 // Instead of converting units, reinterpret the number as having
@@ -1172,10 +1180,10 @@ impl KclValue {
                             value: *n,
                             meta: meta.clone(),
                         };
-                        return ty.coerce(&value);
+                        return ty.coerce(&value, exec_state);
                     }
                 }
-                ty.coerce(self)
+                ty.coerce(self, exec_state)
             }
             PrimitiveType::String => match self {
                 KclValue::String { .. } => Ok(self.clone()),

rust/kcl-lib/src/std/extrude.rs

@@ -105,7 +105,12 @@ async fn inner_extrude(
             (Some(angle), angle_step, center) => {
                 let center = center.clone().map(point_to_mm).map(Point2d::from).unwrap_or_default();
                 let total_rotation_angle = Angle::from_degrees(angle.to_degrees(exec_state, args.source_range));
-                let angle_step_size = Angle::from_degrees(angle_step.clone().map(|a| a.to_degrees(exec_state, args.source_range)).unwrap_or(15.0));
+                let angle_step_size = Angle::from_degrees(
+                    angle_step
+                        .clone()
+                        .map(|a| a.to_degrees(exec_state, args.source_range))
+                        .unwrap_or(15.0),
+                );
                 ModelingCmd::from(mcmd::TwistExtrude {
                     target: sketch.id.into(),
                     distance: LengthUnit(length.to_mm()),