fix(cli): Escape git branch refs for online store-type lookups.

fix(cli): fetch valid store-types from after logging is initialized.

Signed-off-by: spbsoluble <1661003+spbsoluble@users.noreply.github.com>

Author: spbsoluble

cmd/storeTypes.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 	"io"
 	"net/http"
+	"net/url"
 	"os"
 	"sort"
 	"strings"
@@ -93,7 +94,6 @@ var storesTypeCreateCmd = &cobra.Command{
 		gitRef, _ := cmd.Flags().GetString(FlagGitRef)
 		gitRepo, _ := cmd.Flags().GetString(FlagGitRepo)
 		creatAll, _ := cmd.Flags().GetBool("all")
-		validStoreTypes := getValidStoreTypes("", gitRef, gitRepo)
 		storeType, _ := cmd.Flags().GetString("name")
 		listTypes, _ := cmd.Flags().GetBool("list")
 		storeTypeConfigFile, _ := cmd.Flags().GetString("from-file")
@@ -106,6 +106,8 @@ var storesTypeCreateCmd = &cobra.Command{
 		}
 		informDebug(debugFlag)
 
+		validStoreTypes := getValidStoreTypes("", gitRef, gitRepo)
+
 		// Authenticate
 		kfClient, _ := initClient(false)
 
@@ -505,7 +507,8 @@ func getStoreTypesInternet(gitRef string, repo string) (map[string]interface{},
 		fileName = "integration-manifest.json"
 	}
 
-	url := fmt.Sprintf(baseUrl, repo, gitRef, fileName)
+	escapedGitRef := url.PathEscape(gitRef)
+	url := fmt.Sprintf(baseUrl, repo, escapedGitRef, fileName)
 	log.Debug().
 		Str("url", url).
 		Msg("Getting store types from internet")