feat(logging): Enhance LoggerProcessorFactory to merge optional and channel-specific processors

- Updated LoggerProcessorFactory to ensure processors from both channel configurations and optional configurations are correctly merged.
- Adjusted the createProcessors method to handle the merging of processor configurations.
- Ensured that the processors are instantiated with the correct configuration parameters.
- Added utility methods to handle configuration merging and validation.

Author: walmir-silva

src/Processor/LoggerProcessorFactory.php

@@ -14,7 +14,7 @@ class LoggerProcessorFactory implements LoggerConfigurableFactory
     use ReflectionFactoryTrait;
 
     private array $processorMap = [];
-    private array $channelConfigs = [];
+    private LoggerConfiguration $config;
 
     public function initializeFromConfiguration(LoggerConfiguration $config): void
     {
@@ -27,23 +27,54 @@ public function initializeFromConfiguration(LoggerConfiguration $config): void
             'web_processor' => WebProcessor::class,
         ]);
 
-        $this->channelConfigs = $config->get('channels', []);
+        $this->config = $config;
     }
 
     public function createProcessors(string $channelName): array
     {
-        $channelConfig = $this->channelConfigs[$channelName] ?? [];
-        $processorsConfig = $channelConfig['processors'] ?? [];
+        $processorsConfig = $this->getProcessorsConfig($channelName);
         $processors = [];
         foreach ($processorsConfig as $key => $value) {
             [$processorName, $processorOptions] = $this->extractMergedConfig($key, $value);
-
             $processors[] = $this->createProcessor($processorName, $processorOptions);
         }
 
         return $processors;
     }
 
+    private function getProcessorsConfig(string $channelName): array
+    {
+        $channelProcessorConfig = $this->getChannelProcessorsConfig($channelName);
+        $optionalProcessorConfig = $this->getOptionalProcessorsConfig($channelName);
+
+        return array_merge($channelProcessorConfig ?? [], $optionalProcessorConfig ?? []);
+    }
+
+    private function getChannelProcessorsConfig(string $channelName): ?array
+    {
+        $channelConfigs = $this->config->get('channels', []);
+
+        return $channelConfigs[$channelName]['processors'] ?? null;
+    }
+
+    private function getOptionalProcessorsConfig(string $channelName): ?array
+    {
+        $optionalProcessorConfigs = $this->config->get($channelName, []);
+
+        if (!self::isOptionalProcessorEnabled($optionalProcessorConfigs)) {
+            return [];
+        }
+
+        return $optionalProcessorConfigs['processors'] ?? $this->getChannelProcessorsConfig(
+            $optionalProcessorConfigs['channel'] ?? 'file'
+        );
+    }
+
+    private static function isOptionalProcessorEnabled(array $optionalProcessorConfigs): bool
+    {
+        return isset($optionalProcessorConfigs['enabled']) && $optionalProcessorConfigs['enabled'];
+    }
+
     private function createProcessor(string $processorName, array $processorOptions): ProcessorAware
     {
         $processorClass = $this->getClassFromMap($this->processorMap, $processorName);

src/Processor/Metric/CpuUsageProcessor.php

@@ -22,8 +22,7 @@ public function process(ImmutableValue $record): ImmutableValue
             $record->level,
             $record->message,
             $context,
-            $record->datetime,
-            $record->extra
+            $record->datetime
         );
     }
 }

src/Processor/Metric/MemoryUsageProcessor.php

@@ -25,8 +25,7 @@ public function process(ImmutableValue $record): ImmutableValue
             $record->level,
             $record->message,
             $context,
-            $record->datetime,
-            $record->extra
+            $record->datetime
         );
     }
 

tests/application.php

@@ -26,34 +26,34 @@
 
 $serviceProvider->register();
 
-$defaultLogger = $loggerRegistry->getLogger('file');
-$defaultLogger->debug('This is a debug message');
-$defaultLogger->info('This is an info message');
-$defaultLogger->notice('This is a notice message', ['context' => 'notice']);
-$defaultLogger->warning('This is a warning message', ['context' => 'warning']);
-$defaultLogger->error('This is an error message', ['context' => 'error']);
-$defaultLogger->critical('This is a critical message', ['context' => 'critical']);
-$defaultLogger->alert('This is an alert message', ['context' => 'alert']);
-$defaultLogger->emergency('This is an emergency message', ['context' => 'emergency']);
-
-$asyncLogger = $loggerRegistry->getLogger('async');
-if ($asyncLogger) {
-    for ($i = 0; $i < 3; ++$i) {
-        $asyncLogger->info("Async log message {$i}", ['context' => "batch {$i}"]);
-    }
-}
-
-$queryLogger = $loggerRegistry->getLogger('query');
-$queryLogger->info('Executing a query', ['time' => 90, 'query' => 'SELECT * FROM users', 'bindings' => []]);
-
-$queryLogger = $loggerRegistry->getLogger('query');
-$queryLogger->info('Executing a query', ['query' => 'SELECT * FROM users', 'bindings' => []]);
+// $defaultLogger = $loggerRegistry->getLogger('console');
+// $defaultLogger->debug('This is a debug message');
+// $defaultLogger->info('This is an info message');
+// $defaultLogger->notice('This is a notice message', ['context' => 'notice']);
+// $defaultLogger->warning('This is a warning message', ['context' => 'warning']);
+// $defaultLogger->error('This is an error message', ['context' => 'error']);
+// $defaultLogger->critical('This is a critical message', ['context' => 'critical']);
+// $defaultLogger->alert('This is an alert message', ['context' => 'alert']);
+// $defaultLogger->emergency('This is an emergency message', ['context' => 'emergency']);
+
+// $asyncLogger = $loggerRegistry->getLogger('async');
+// if ($asyncLogger) {
+//     for ($i = 0; $i < 3; ++$i) {
+//         $asyncLogger->info("Async log message {$i}", ['context' => "batch {$i}"]);
+//     }
+// }
+
+// $queryLogger = $loggerRegistry->getLogger('query');
+// $queryLogger->info('Executing a query', ['time' => 90, 'query' => 'SELECT * FROM users', 'bindings' => []]);
+
+// $queryLogger = $loggerRegistry->getLogger('query');
+// $queryLogger->info('Executing a query', ['query' => 'SELECT * FROM users', 'bindings' => []]);
 
 $performanceLogger = $loggerRegistry->getLogger('performance');
-$performanceLogger->debug('Performance logging', ['execution_time' => 100, 'additional_context' => 'example']);
+$performanceLogger->debug('Performance logging', ['execution_time' => 1000, 'additional_context' => 'example']);
 
-$performanceLogger = $loggerRegistry->getLogger('performance');
-$performanceLogger->debug('Performance logging', ['additional_context' => 'example']);
+// $performanceLogger = $loggerRegistry->getLogger('performance');
+// $performanceLogger->debug('Performance logging');
 
 // // // Testa o error logger
 // // if (LoggerRegistry::getLogger('error')) {