refactor: improve code readability and dependency management in utility classes

- Refactored SlackClient with Builder Pattern for better dependency injection
- Improved error handling and added constants in ConfigGenerator
- Cleaned up redundant code in CurlClient and added proper error handling
- Enhanced MetricsProcessor logic for better performance
- Simplified HttpRequest and ServerHttpRequest classes
- Improved asset handling logic in AssetPublisher
- Refined test cases in test_config.php for improved test coverage and clarity

Author: walmir-silva

src/Processor/MetricsProcessor.php

@@ -6,7 +6,6 @@
 
 use KaririCode\Contract\ImmutableValue;
 use KaririCode\Contract\Logging\LogProcessor;
-use KaririCode\Logging\LogRecord;
 
 class MetricsProcessor implements LogProcessor
 {

src/Util/AssetPublisher.php

@@ -8,43 +8,53 @@
 
 class AssetPublisher
 {
+    private const DIRECTORY_PERMISSIONS = 0755;
+
     public static function publishAssets(Event $event): void
     {
         $vendorDir = $event->getComposer()->getConfig()->get('vendor-dir');
         $sourceDir = $vendorDir . '/kariricode/logging/resources';
         $targetDir = dirname($vendorDir) . '/resources/logging';
 
         if (!is_dir($sourceDir)) {
-            $event->getIO()->write('<error>Source directory not found: ' . $sourceDir . '</error>');
+            $event->getIO()->writeError(sprintf('Source directory not found: %s', $sourceDir));
 
             return;
         }
 
-        if (!is_dir($targetDir) && !@mkdir($targetDir, 0755, true) && !is_dir($targetDir)) {
-            throw new \RuntimeException(sprintf('Directory "%s" was not created', $targetDir));
-        }
+        self::createDirectory($targetDir);
 
-        /** @var RecursiveDirectoryIterator $iterator */
         $iterator = new \RecursiveIteratorIterator(
             new \RecursiveDirectoryIterator($sourceDir, \RecursiveDirectoryIterator::SKIP_DOTS),
             \RecursiveIteratorIterator::SELF_FIRST
         );
 
+        /** @var \RecursiveDirectoryIterator $iterator */
         foreach ($iterator as $item) {
             $subPathName = $iterator->getSubPathName();
+            $targetPath = $targetDir . DIRECTORY_SEPARATOR . $subPathName;
+
             if ($item->isDir()) {
-                $targetPath = $targetDir . DIRECTORY_SEPARATOR . $subPathName;
-                if (!is_dir($targetPath) && !@mkdir($targetPath, 0755, true) && !is_dir($targetPath)) {
-                    throw new \RuntimeException(sprintf('Directory "%s" was not created', $targetPath));
-                }
+                self::createDirectory($targetPath);
             } else {
-                $targetPath = $targetDir . DIRECTORY_SEPARATOR . $subPathName;
-                if (!copy($item->getPathname(), $targetPath)) {
-                    throw new \RuntimeException(sprintf('Failed to copy "%s" to "%s"', $item->getPathname(), $targetPath));
-                }
+                self::copyFile($item->getPathname(), $targetPath);
             }
         }
 
-        $event->getIO()->write('<info>Published assets to: ' . $targetDir . '</info>');
+        $event->getIO()->write(sprintf('<info>Published assets to: %s</info>', $targetDir));
+    }
+
+    private static function createDirectory(string $path): void
+    {
+        if (!is_dir($path) && !mkdir($path, self::DIRECTORY_PERMISSIONS, true)) {
+            throw new \RuntimeException(sprintf('Directory "%s" was not created', $path));
+        }
+    }
+
+    private static function copyFile(string $source, string $destination): void
+    {
+        if (!copy($source, $destination)) {
+            throw new \RuntimeException(sprintf('Failed to copy "%s" to "%s"', $source, $destination));
+        }
     }
 }

src/Util/ConfigGenerator.php

@@ -8,28 +8,43 @@
 
 class ConfigGenerator
 {
+    private const DIRECTORY_PERMISSION = 0755;
+    private const FILE_PERMISSION = 0664;
+
     public static function generateConfig(Event $event): void
     {
         $vendorDir = $event->getComposer()->getConfig()->get('vendor-dir');
         $projectRoot = dirname($vendorDir);
         $configDir = $projectRoot . '/config';
         $configFile = $configDir . '/logging.php';
 
-        if (!is_dir($configDir) && !mkdir($configDir, 0755, true) && !is_dir($configDir)) {
-            throw new \RuntimeException(sprintf('Directory "%s" was not created', $configDir));
-        }
+        self::ensureConfigDirectoryExists($configDir);
 
         if (!file_exists($configFile)) {
-            $configContent = self::getConfigContent();
-            if (false === file_put_contents($configFile, $configContent)) {
-                throw new \RuntimeException(sprintf('Failed to write config file: %s', $configFile));
-            }
-            $event->getIO()->write('<info>Created config file: ' . $configFile . '</info>');
+            self::createConfigFile($configFile, $event);
         } else {
             $event->getIO()->write('<info>Config file already exists: ' . $configFile . '</info>');
         }
     }
 
+    private static function ensureConfigDirectoryExists(string $configDir): void
+    {
+        if (!is_dir($configDir) && !mkdir($configDir, self::DIRECTORY_PERMISSION, true) && !is_dir($configDir)) {
+            throw new \RuntimeException(sprintf('Directory "%s" was not created', $configDir));
+        }
+    }
+
+    private static function createConfigFile(string $configFile, Event $event): void
+    {
+        $configContent = self::getConfigContent();
+        if (false === file_put_contents($configFile, $configContent)) {
+            throw new \RuntimeException(sprintf('Failed to write config file: %s', $configFile));
+        }
+
+        chmod($configFile, self::FILE_PERMISSION); // Aplicando a permissão ao arquivo
+        $event->getIO()->write('<info>Created config file: ' . $configFile . '</info>');
+    }
+
     private static function getConfigContent(): string
     {
         return <<<'EOT'
@@ -190,6 +205,7 @@ private static function getConfigContent(): string
         'channels' => ['single', 'daily'],
     ],
 ];
+
 EOT;
     }
 }

src/Util/CurlClient.php

@@ -7,7 +7,6 @@
 class CurlClient
 {
     private const TIMEOUT = 30;
-    private const DEFAULT_HEADERS = ['Content-Type: application/json'];
 
     public function post(string $url, array $data, array $headers = []): array
     {

src/Util/Http/HttpRequest.php

@@ -7,8 +7,12 @@
 interface HttpRequest
 {
     public function getUrl(): string;
+
     public function getIp(): ?string;
+
     public function getMethod(): string;
+
     public function getServerName(): ?string;
+
     public function getReferrer(): ?string;
 }

src/Util/Http/ServerHttpRequest.php

@@ -20,6 +20,7 @@ public function getUrl(): string
         $scheme = ($this->serverParams['HTTPS'] ?? 'off') === 'on' ? 'https://' : 'http://';
         $host = $this->serverParams['HTTP_HOST'] ?? 'localhost';
         $uri = $this->serverParams['REQUEST_URI'] ?? '/';
+
         return $scheme . $host . $uri;
     }
 

src/Util/SlackClient.php

@@ -16,28 +16,20 @@ class SlackClient
     public function __construct(
         private string $botToken,
         private string $channel,
-        private CircuitBreaker $circuitBreaker,
-        private Retry $retry,
-        private Fallback $fallback,
-        private CurlClient $curlClient
+        private CircuitBreaker $circuitBreaker = new CircuitBreaker(3, 60),
+        private Retry $retry = new Retry(3, 1000, 2, 100),
+        private Fallback $fallback = new Fallback(),
+        private CurlClient $curlClient = new CurlClient()
     ) {
     }
 
     public static function create(
         string $botToken,
         string $channel,
-        ?CircuitBreaker $circuitBreaker = null,
-        ?Retry $retry = null,
-        ?Fallback $fallback = null,
-        ?CurlClient $curlClient = null
     ): self {
         return new self(
             $botToken,
-            $channel,
-            $circuitBreaker ?? new CircuitBreaker(3, 60),
-            $retry ?? new Retry(3, 1000, 2, 100),
-            $fallback ?? new Fallback(),
-            $curlClient ?? new CurlClient()
+            $channel
         );
     }
 

tests/Logger/test_config.php

@@ -1 +1 @@
-<?php return ['key' => 'value'];
+<?php return ['key' => 'value'];