Skip to content

Commit 68c89f4

Browse files
authored
Rename UserRole to DatasetCollaborator in kagglesdk (#651)
1 parent 963d26e commit 68c89f4

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

kaggle/api/kaggle_api_extended.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
from kagglesdk.datasets.types.dataset_enums import DatasetSelectionGroup, \
6868
DatasetSortBy, DatasetFileTypeGroup, DatasetLicenseGroup
6969
from kagglesdk.datasets.types.dataset_types import DatasetSettings, \
70-
SettingsLicense, UserRole, DatasetSettingsFile
70+
SettingsLicense, DatasetCollaborator, DatasetSettingsFile
7171
from kagglesdk.kernels.types.kernels_api_service import ApiListKernelsRequest, \
7272
ApiListKernelFilesRequest, ApiSaveKernelRequest, ApiGetKernelRequest, \
7373
ApiListKernelSessionOutputRequest, ApiGetKernelSessionStatusRequest

kagglesdk/datasets/types/dataset_types.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class DatasetInfo(KaggleObject):
2020
is_private (bool)
2121
keywords (str)
2222
licenses (SettingsLicense)
23-
collaborators (UserRole)
23+
collaborators (DatasetCollaborator)
2424
data (DatasetSettingsFile)
2525
"""
2626

@@ -220,18 +220,18 @@ def licenses(self, licenses: Optional[List[Optional['SettingsLicense']]]):
220220
self._licenses = licenses
221221

222222
@property
223-
def collaborators(self) -> Optional[List[Optional['UserRole']]]:
223+
def collaborators(self) -> Optional[List[Optional['DatasetCollaborator']]]:
224224
return self._collaborators
225225

226226
@collaborators.setter
227-
def collaborators(self, collaborators: Optional[List[Optional['UserRole']]]):
227+
def collaborators(self, collaborators: Optional[List[Optional['DatasetCollaborator']]]):
228228
if collaborators is None:
229229
del self.collaborators
230230
return
231231
if not isinstance(collaborators, list):
232232
raise TypeError('collaborators must be of type list')
233-
if not all([isinstance(t, UserRole) for t in collaborators]):
234-
raise TypeError('collaborators must contain only items of type UserRole')
233+
if not all([isinstance(t, DatasetCollaborator) for t in collaborators]):
234+
raise TypeError('collaborators must contain only items of type DatasetCollaborator')
235235
self._collaborators = collaborators
236236

237237
@property
@@ -259,7 +259,7 @@ class DatasetSettings(KaggleObject):
259259
is_private (bool)
260260
keywords (str)
261261
licenses (SettingsLicense)
262-
collaborators (UserRole)
262+
collaborators (DatasetCollaborator)
263263
data (DatasetSettingsFile)
264264
"""
265265

@@ -357,18 +357,18 @@ def licenses(self, licenses: Optional[List[Optional['SettingsLicense']]]):
357357
self._licenses = licenses
358358

359359
@property
360-
def collaborators(self) -> Optional[List[Optional['UserRole']]]:
360+
def collaborators(self) -> Optional[List[Optional['DatasetCollaborator']]]:
361361
return self._collaborators
362362

363363
@collaborators.setter
364-
def collaborators(self, collaborators: Optional[List[Optional['UserRole']]]):
364+
def collaborators(self, collaborators: Optional[List[Optional['DatasetCollaborator']]]):
365365
if collaborators is None:
366366
del self.collaborators
367367
return
368368
if not isinstance(collaborators, list):
369369
raise TypeError('collaborators must be of type list')
370-
if not all([isinstance(t, UserRole) for t in collaborators]):
371-
raise TypeError('collaborators must contain only items of type UserRole')
370+
if not all([isinstance(t, DatasetCollaborator) for t in collaborators]):
371+
raise TypeError('collaborators must contain only items of type DatasetCollaborator')
372372
self._collaborators = collaborators
373373

374374
@property
@@ -536,7 +536,7 @@ def name(self, name: str):
536536
self._name = name
537537

538538

539-
class UserRole(KaggleObject):
539+
class DatasetCollaborator(KaggleObject):
540540
r"""
541541
Attributes:
542542
username (str)
@@ -589,7 +589,7 @@ def role(self, role: 'CollaboratorType'):
589589
FieldMetadata("isPrivate", "is_private", "_is_private", bool, False, PredefinedSerializer()),
590590
FieldMetadata("keywords", "keywords", "_keywords", str, [], ListSerializer(PredefinedSerializer())),
591591
FieldMetadata("licenses", "licenses", "_licenses", SettingsLicense, [], ListSerializer(KaggleObjectSerializer())),
592-
FieldMetadata("collaborators", "collaborators", "_collaborators", UserRole, [], ListSerializer(KaggleObjectSerializer())),
592+
FieldMetadata("collaborators", "collaborators", "_collaborators", DatasetCollaborator, [], ListSerializer(KaggleObjectSerializer())),
593593
FieldMetadata("data", "data", "_data", DatasetSettingsFile, [], ListSerializer(KaggleObjectSerializer())),
594594
]
595595

@@ -600,7 +600,7 @@ def role(self, role: 'CollaboratorType'):
600600
FieldMetadata("isPrivate", "is_private", "_is_private", bool, False, PredefinedSerializer()),
601601
FieldMetadata("keywords", "keywords", "_keywords", str, [], ListSerializer(PredefinedSerializer())),
602602
FieldMetadata("licenses", "licenses", "_licenses", SettingsLicense, [], ListSerializer(KaggleObjectSerializer())),
603-
FieldMetadata("collaborators", "collaborators", "_collaborators", UserRole, [], ListSerializer(KaggleObjectSerializer())),
603+
FieldMetadata("collaborators", "collaborators", "_collaborators", DatasetCollaborator, [], ListSerializer(KaggleObjectSerializer())),
604604
FieldMetadata("data", "data", "_data", DatasetSettingsFile, [], ListSerializer(KaggleObjectSerializer())),
605605
]
606606

@@ -621,7 +621,7 @@ def role(self, role: 'CollaboratorType'):
621621
FieldMetadata("name", "name", "_name", str, None, PredefinedSerializer(), optional=True),
622622
]
623623

624-
UserRole._fields = [
624+
DatasetCollaborator._fields = [
625625
FieldMetadata("username", "username", "_username", str, "", PredefinedSerializer()),
626626
FieldMetadata("role", "role", "_role", CollaboratorType, CollaboratorType.COLLABORATOR_TYPE_UNSPECIFIED, EnumSerializer()),
627627
]

src/kaggle/api/kaggle_api_extended.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
from kagglesdk.datasets.types.dataset_enums import DatasetSelectionGroup, \
5252
DatasetSortBy, DatasetFileTypeGroup, DatasetLicenseGroup
5353
from kagglesdk.datasets.types.dataset_types import DatasetSettings, \
54-
SettingsLicense, UserRole, DatasetSettingsFile
54+
SettingsLicense, DatasetCollaborator, DatasetSettingsFile
5555
from kagglesdk.kernels.types.kernels_api_service import ApiListKernelsRequest, \
5656
ApiListKernelFilesRequest, ApiSaveKernelRequest, ApiGetKernelRequest, \
5757
ApiListKernelSessionOutputRequest, ApiGetKernelSessionStatusRequest

0 commit comments

Comments
 (0)