Skip to content

Commit 341ff73

Browse files
chrisgorgorysteboe
authored andcommitted
docstring and better variable name
1 parent 1057c5b commit 341ff73

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

kaggle/api/kaggle_api_extended.py

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2229,8 +2229,8 @@ def upload_files(self, request, resources, folder, quiet=False):
22292229
full_path = os.path.join(folder, file_name)
22302230

22312231
if os.path.isfile(full_path):
2232-
retval = self._upload_file(file_name, full_path, quiet, request, resources)
2233-
if retval:
2232+
exitcode = self._upload_file(file_name, full_path, quiet, request, resources)
2233+
if exitcode:
22342234
return
22352235
if os.path.isdir(full_path):
22362236
temp_dir = tempfile.mkdtemp()
@@ -2239,17 +2239,28 @@ def upload_files(self, request, resources, folder, quiet=False):
22392239
archive_path = shutil.make_archive(os.path.join(temp_dir, dir_name), "zip",
22402240
full_path)
22412241
_, archive_name = os.path.split(archive_path)
2242-
retval = self._upload_file(archive_name, archive_path, quiet, request,
2243-
resources)
2242+
exitcode = self._upload_file(archive_name, archive_path, quiet, request,
2243+
resources)
22442244
finally:
22452245
shutil.rmtree(temp_dir)
2246-
if retval:
2246+
if exitcode:
22472247
return
22482248
else:
22492249
if not quiet:
22502250
print('Skipping: ' + file_name)
22512251

22522252
def _upload_file(self, file_name, full_path, quiet, request, resources):
2253+
""" Helper function to upload a single file
2254+
Parameters
2255+
==========
2256+
file_name: name of the file to upload
2257+
full_path: path to the file to upload
2258+
request: the prepared request
2259+
resources: the files to upload
2260+
quiet: suppress verbose output
2261+
:return: True - upload unsuccessful; False - upload successful
2262+
"""
2263+
22532264
if not quiet:
22542265
print('Starting upload for file ' + file_name)
22552266

0 commit comments

Comments
 (0)