Skip to content

Commit 97ab4b8

Browse files
authored
Fix pytorch lightning test. (#1019)
In 1.3.x, trainer.fit(...) returns None. Asserting on trainer.logged_metrics instead. http://b/188429515
1 parent 597bc2a commit 97ab4b8

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

tests/test_pytorch_lightning.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ def setup(self, stage=None):
2323
self.valid_ds = TensorDataset(X_valid, y_valid)
2424

2525
def train_dataloader(self):
26-
return DataLoader(self.train_ds, batch_size=self.batch_size, shuffle=True)
26+
return DataLoader(self.train_ds, batch_size=self.batch_size, shuffle=True, num_workers=1)
2727

2828
def val_dataloader(self):
29-
return DataLoader(self.valid_ds, batch_size=self.batch_size, shuffle=False)
29+
return DataLoader(self.valid_ds, batch_size=self.batch_size, shuffle=False, num_workers=1)
3030

3131

3232
class LitClassifier(pl.LightningModule):
@@ -54,7 +54,6 @@ def validation_step(self, batch, batch_idx):
5454
def configure_optimizers(self):
5555
return torch.optim.Adam(self.parameters(), lr=1e-2)
5656

57-
5857
class TestPytorchLightning(unittest.TestCase):
5958

6059
def test_version(self):
@@ -64,5 +63,8 @@ def test_mnist(self):
6463
dm = LitDataModule()
6564
model = LitClassifier()
6665
trainer = pl.Trainer(gpus=None, max_epochs=1)
67-
result = trainer.fit(model, datamodule=dm)
68-
self.assertTrue(result)
66+
trainer.fit(model, datamodule=dm)
67+
68+
self.assertIn("train_loss", trainer.logged_metrics)
69+
self.assertIn("val_loss", trainer.logged_metrics)
70+

0 commit comments

Comments
 (0)