From 1fcc2c70edb2bba4c456954660fc6a8f2e639cf4 Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Wed, 12 Jun 2024 19:50:48 +0200 Subject: [PATCH 01/11] chore: bump github workflow actions to v4 (compatible with node 20) --- .github/workflows/devpackpublish.yml | 4 +-- .github/workflows/docpublish.yml | 2 +- .github/workflows/npmpublish-rc.yml | 14 ++++----- .github/workflows/npmpublish.yml | 12 ++++---- .github/workflows/test-node-candidate.yml | 25 ++++++++-------- .github/workflows/tests-polkadot-deps.yml | 14 ++++----- .github/workflows/tests.yml | 35 +++++++++++------------ 7 files changed, 52 insertions(+), 54 deletions(-) diff --git a/.github/workflows/devpackpublish.yml b/.github/workflows/devpackpublish.yml index 0ae25a497..4ba79507e 100644 --- a/.github/workflows/devpackpublish.yml +++ b/.github/workflows/devpackpublish.yml @@ -6,12 +6,12 @@ jobs: runs-on: ubuntu-latest if: "! startsWith(github.event.head_commit.message, '[CI Skip]') && github.repository == 'kiltprotocol/sdk-js'" steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: # fetch-depth 0 and token needed to push changes on the package.json files back. fetch-depth: 0 token: ${{ secrets.REPO_ACCESS_TOKEN }} - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: 'yarn' diff --git a/.github/workflows/docpublish.yml b/.github/workflows/docpublish.yml index 6d075f62a..c9c5a8e54 100644 --- a/.github/workflows/docpublish.yml +++ b/.github/workflows/docpublish.yml @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Install and Build run: | diff --git a/.github/workflows/npmpublish-rc.yml b/.github/workflows/npmpublish-rc.yml index 97b7586b2..f7cd5b20e 100644 --- a/.github/workflows/npmpublish-rc.yml +++ b/.github/workflows/npmpublish-rc.yml @@ -18,8 +18,8 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: 'yarn' @@ -31,8 +31,8 @@ jobs: needs: build runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: 'yarn' @@ -44,9 +44,9 @@ jobs: run: yarn run bundle - name: Get current package version id: package_version - run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT + run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT - name: Publish to NPM - run: yarn run publish --tag ${{ inputs.npm_tag }} + run: yarn run publish --tag ${{ inputs.npm_tag }} env: YARN_NPM_AUTH_TOKEN: ${{secrets.npm_token}} - name: Repository Dispatch @@ -55,4 +55,4 @@ jobs: token: ${{ secrets.REPO_ACCESS_TOKEN }} repository: KILTProtocol/docs event-type: sdk-update - client-payload: '{"latestTag": "${{ steps.package_version.outputs.package_version }}"}' + client-payload: '{"latestTag": "${{ steps.package_version.outputs.package_version }}"}' diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index 69f679d51..93ffad411 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -6,8 +6,8 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: 'yarn' @@ -19,8 +19,8 @@ jobs: needs: build runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: 'yarn' @@ -32,7 +32,7 @@ jobs: run: yarn run bundle - name: Get current package version id: package_version - run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT + run: echo "package_version=$(node -pe "require('./package.json').version")" >> $GITHUB_OUTPUT - name: Publish to NPM run: yarn run publish --tag latest env: @@ -43,4 +43,4 @@ jobs: token: ${{ secrets.REPO_ACCESS_TOKEN }} repository: KILTProtocol/docs event-type: sdk-update - client-payload: '{"latestTag": "${{ steps.package_version.outputs.package_version }}"}' + client-payload: '{"latestTag": "${{ steps.package_version.outputs.package_version }}"}' diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 47e249598..1aa38184b 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -12,14 +12,13 @@ env: TESTCONTAINERS_WATCHER_IMG: testcontainers/ryuk:0.3.2 jobs: - build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: 'yarn' @@ -30,7 +29,7 @@ jobs: - name: zip build run: zip -r build.zip . - name: upload build - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: build path: build.zip @@ -39,7 +38,7 @@ jobs: runs-on: ubuntu-latest needs: build steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: make sure testcontainers image is in cache uses: ./.github/actions/cached-image-pull with: @@ -51,13 +50,13 @@ jobs: needs: cache_imgs steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build - name: unzip run: unzip build.zip -d . - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - name: Log out node version @@ -97,19 +96,19 @@ jobs: needs: build steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build - name: unzip run: unzip build.zip -d . - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - name: yarn bundle run: yarn bundle - name: upload bundle artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: checked-nonmin-bundle path: packages/sdk-js/dist/sdk-js.umd.js @@ -120,16 +119,16 @@ jobs: needs: [cache_imgs, bundle_cache] steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build - name: unzip run: unzip build.zip -d . - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: checked-nonmin-bundle path: packages/sdk-js/dist - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - run: basename /packages/sdk-js/dist/ diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index b14047507..a5d0b8e04 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -16,11 +16,11 @@ jobs: node-version: [18.x, 20.x] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: master - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} cache: 'yarn' @@ -35,7 +35,7 @@ jobs: - name: list dependencies run: echo "$(yarn info -A --name-only --json)" > locked_dependencies.txt - name: upload dependencies list - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: deps-${{ matrix.node-version }} path: | @@ -47,7 +47,7 @@ jobs: - name: zip build run: zip -r build.zip . - name: upload build - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: build-${{ matrix.node-version }} path: build.zip @@ -67,7 +67,7 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build-${{ matrix.node-version }} - name: unzip @@ -91,7 +91,7 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build-20.x - name: unzip @@ -135,7 +135,7 @@ jobs: needs: [test, integration_test] if: failure() steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: deps-20.x - name: set dependencies env diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 54958f5a1..4ab152fbf 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -37,9 +37,9 @@ jobs: needs: check_skip steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' cache: 'yarn' @@ -50,7 +50,7 @@ jobs: - name: zip build run: zip -r build.zip . - name: upload build - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: build path: build.zip @@ -60,13 +60,13 @@ jobs: needs: build steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build - name: unzip run: unzip build.zip -d . - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - name: lint @@ -90,10 +90,10 @@ jobs: steps: - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build - name: unzip @@ -107,7 +107,7 @@ jobs: runs-on: ubuntu-latest needs: build steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: make sure testcontainers image is in cache uses: ./.github/actions/cached-image-pull with: @@ -129,13 +129,13 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build - name: unzip run: unzip build.zip -d . - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - name: Log out node version @@ -169,30 +169,29 @@ jobs: - name: run integration tests (cjs) timeout-minutes: 60 run: yarn test:integration -b - + - name: run integration tests (esm) timeout-minutes: 60 run: yarn test:integration:esm -b - bundle_cache: runs-on: ubuntu-latest needs: build steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build - name: unzip run: unzip build.zip -d . - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' - name: yarn bundle run: yarn bundle - name: upload bundle artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: checked-nonmin-bundle path: packages/sdk-js/dist/sdk-js.umd.js @@ -211,17 +210,17 @@ jobs: continue-on-error: ${{ matrix.required == 'optional' }} steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: build - name: unzip run: unzip build.zip -d . - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: checked-nonmin-bundle path: packages/sdk-js/dist - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' From c0f1d02dcf34348ace56d618e9abdc19bf4565f4 Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Wed, 12 Jun 2024 19:51:42 +0200 Subject: [PATCH 02/11] chore: update action in action to v4 --- .github/actions/cached-image-pull/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/cached-image-pull/action.yml b/.github/actions/cached-image-pull/action.yml index 351bb3e6a..efcb0201e 100644 --- a/.github/actions/cached-image-pull/action.yml +++ b/.github/actions/cached-image-pull/action.yml @@ -27,7 +27,7 @@ runs: - name: check image cache id: image-cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ${{ steps.image-file.outputs.path }} key: image-cache-${{ inputs.image }} From c2df14722a0dcf3c4387f826041508bf92822ad7 Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Wed, 12 Jun 2024 20:00:49 +0200 Subject: [PATCH 03/11] fix: use docker image with node 20 pre-installed --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 30cb813e1..89e488862 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:alpine +FROM node:20-alpine WORKDIR /app From 5ef6bf2d6472cc8d2b3dbb74098b8e615fcf0a12 Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Wed, 12 Jun 2024 21:19:51 +0200 Subject: [PATCH 04/11] fix: try to fox integration tests --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 89e488862..30cb813e1 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:20-alpine +FROM node:alpine WORKDIR /app From fcf4b87937491fbfe09a355da8727d823ad5e5d7 Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Wed, 12 Jun 2024 21:31:14 +0200 Subject: [PATCH 05/11] feat: test against node v22 on workflows as well --- .github/workflows/tests-polkadot-deps.yml | 4 ++-- .github/workflows/tests.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index a5d0b8e04..4f3427a44 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -13,7 +13,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x] + node-version: [18.x, 20.x, 22.x] steps: - uses: actions/checkout@v4 @@ -58,7 +58,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x] + node-version: [18.x, 20.x, 22.x] required: ['required'] include: - node-version: 16.x diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 4ab152fbf..f2ec464ce 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -80,7 +80,7 @@ jobs: strategy: matrix: - node-version: [18, 20] + node-version: [18, 20, 22] required: ['required'] include: - node-version: 16 From 2afc5feb80d86f612c5124044c76b12738cbb3b4 Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Mon, 17 Jun 2024 13:20:52 +0200 Subject: [PATCH 06/11] fix: make node v22 on github workflows optional --- .github/workflows/tests-polkadot-deps.yml | 4 ++-- .github/workflows/tests.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index 4f3427a44..db6f3f8e1 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -58,10 +58,10 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, 22.x] + node-version: [18.x, 20.x] required: ['required'] include: - - node-version: 16.x + - node-version: [16.x, 22.x] required: 'optional' continue-on-error: ${{ matrix.required == 'optional' }} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f2ec464ce..1b45206a7 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -80,10 +80,10 @@ jobs: strategy: matrix: - node-version: [18, 20, 22] + node-version: [18, 20] required: ['required'] include: - - node-version: 16 + - node-version: [16, 22] required: 'optional' continue-on-error: ${{ matrix.required == 'optional' }} From bddedbcb8b978c70ed545f9fec5db47d748f987c Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Mon, 17 Jun 2024 14:40:11 +0200 Subject: [PATCH 07/11] fix: fix: make node v22 on github workflows optional --- .github/workflows/tests-polkadot-deps.yml | 4 +++- .github/workflows/tests.yml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index db6f3f8e1..c72861e8a 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -61,7 +61,9 @@ jobs: node-version: [18.x, 20.x] required: ['required'] include: - - node-version: [16.x, 22.x] + - node-version: 16.x + required: 'optional' + - node-version: 22.x required: 'optional' continue-on-error: ${{ matrix.required == 'optional' }} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1b45206a7..343255c59 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -83,7 +83,9 @@ jobs: node-version: [18, 20] required: ['required'] include: - - node-version: [16, 22] + - node-version: 16 + required: 'optional' + - node-version: 22 required: 'optional' continue-on-error: ${{ matrix.required == 'optional' }} From 87fea3a453c9e5a69af5a5f6eb3081ae05dccd43 Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Mon, 17 Jun 2024 15:25:57 +0200 Subject: [PATCH 08/11] fix: try to reproduce green checks --- .github/workflows/tests-polkadot-deps.yml | 4 +--- .github/workflows/tests.yml | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index c72861e8a..4f3427a44 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -58,13 +58,11 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x] + node-version: [18.x, 20.x, 22.x] required: ['required'] include: - node-version: 16.x required: 'optional' - - node-version: 22.x - required: 'optional' continue-on-error: ${{ matrix.required == 'optional' }} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 343255c59..f2ec464ce 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -80,13 +80,11 @@ jobs: strategy: matrix: - node-version: [18, 20] + node-version: [18, 20, 22] required: ['required'] include: - node-version: 16 required: 'optional' - - node-version: 22 - required: 'optional' continue-on-error: ${{ matrix.required == 'optional' }} From ada4a7487807099deb67529514505ee029b9476b Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Tue, 2 Jul 2024 18:04:09 +0200 Subject: [PATCH 09/11] fix: last try to make node v22 optional --- .github/workflows/tests-polkadot-deps.yml | 4 +++- .github/workflows/tests.yml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index 4f3427a44..c72861e8a 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -58,11 +58,13 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, 22.x] + node-version: [18.x, 20.x] required: ['required'] include: - node-version: 16.x required: 'optional' + - node-version: 22.x + required: 'optional' continue-on-error: ${{ matrix.required == 'optional' }} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f2ec464ce..343255c59 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -80,11 +80,13 @@ jobs: strategy: matrix: - node-version: [18, 20, 22] + node-version: [18, 20] required: ['required'] include: - node-version: 16 required: 'optional' + - node-version: 22 + required: 'optional' continue-on-error: ${{ matrix.required == 'optional' }} From 3979601b84750d3d953657a6a5a47dbce220fb50 Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Wed, 3 Jul 2024 18:48:37 +0200 Subject: [PATCH 10/11] chore: update aws action to use node 20 = bump to v4 --- .github/workflows/test-node-candidate.yml | 4 ++-- .github/workflows/tests.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 1aa38184b..2700486eb 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -63,7 +63,7 @@ jobs: run: node --version - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v2 + uses: aws-actions/configure-aws-credentials@v4 with: aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} @@ -133,7 +133,7 @@ jobs: node-version-file: '.nvmrc' - run: basename /packages/sdk-js/dist/ - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v2 + uses: aws-actions/configure-aws-credentials@v4 with: aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 343255c59..f017f22b4 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -144,7 +144,7 @@ jobs: run: node --version - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v2 + uses: aws-actions/configure-aws-credentials@v4 with: aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} @@ -227,7 +227,7 @@ jobs: node-version-file: '.nvmrc' - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v2 + uses: aws-actions/configure-aws-credentials@v4 with: aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} From c4b1e558576ba663afd5945bc393bf9e33cbbde0 Mon Sep 17 00:00:00 2001 From: kilted-andres Date: Mon, 8 Jul 2024 11:45:36 +0200 Subject: [PATCH 11/11] chore: update other aws action to use node 20 = bump to v2 --- .github/workflows/test-node-candidate.yml | 4 ++-- .github/workflows/tests-polkadot-deps.yml | 4 ++-- .github/workflows/tests.yml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test-node-candidate.yml b/.github/workflows/test-node-candidate.yml index 2700486eb..40b805568 100644 --- a/.github/workflows/test-node-candidate.yml +++ b/.github/workflows/test-node-candidate.yml @@ -71,7 +71,7 @@ jobs: - name: Login to Amazon ECR id: login-ecr - uses: aws-actions/amazon-ecr-login@v1 + uses: aws-actions/amazon-ecr-login@v2 - name: pull image env: @@ -141,7 +141,7 @@ jobs: - name: Login to Amazon ECR id: login-ecr - uses: aws-actions/amazon-ecr-login@v1 + uses: aws-actions/amazon-ecr-login@v2 - name: pull node image env: ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }} diff --git a/.github/workflows/tests-polkadot-deps.yml b/.github/workflows/tests-polkadot-deps.yml index c72861e8a..0d5ebedb4 100644 --- a/.github/workflows/tests-polkadot-deps.yml +++ b/.github/workflows/tests-polkadot-deps.yml @@ -108,9 +108,9 @@ jobs: - name: Login to Amazon ECR id: login-ecr - uses: aws-actions/amazon-ecr-login@v1 + uses: aws-actions/amazon-ecr-login@v2 - - name: pull image + - name: pull node image env: ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }} ECR_REPOSITORY: kilt/prototype-chain diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f017f22b4..6af8a2690 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -152,7 +152,7 @@ jobs: - name: Login to Amazon ECR id: login-ecr - uses: aws-actions/amazon-ecr-login@v1 + uses: aws-actions/amazon-ecr-login@v2 - name: pull image env: @@ -235,7 +235,7 @@ jobs: - name: Login to Amazon ECR id: login-ecr - uses: aws-actions/amazon-ecr-login@v1 + uses: aws-actions/amazon-ecr-login@v2 - run: basename /packages/sdk-js/dist/ - name: pull node image env: