From bef1d56eb91225541160a9e9841f3902d18f9d90 Mon Sep 17 00:00:00 2001 From: dudleyneedham Date: Fri, 17 May 2024 15:55:26 +0200 Subject: [PATCH 1/3] fix: docker image tag for develop updated --- docker-compose.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker-compose.yml b/docker-compose.yml index e756bddd8..017bd7aab 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -13,7 +13,7 @@ version: '3.2' services: dev-node: - image: kiltprotocol/standalone-node:develop + image: kiltprotocol/standalone-node:latest-develop command: '--dev --ws-port 9944 --ws-external' sdk: From dd53af13e724119109561c176a6362fd8633396e Mon Sep 17 00:00:00 2001 From: dudleyneedham Date: Fri, 17 May 2024 16:20:37 +0200 Subject: [PATCH 2/3] fix: updating the get started test container --- docker-compose.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker-compose.yml b/docker-compose.yml index 017bd7aab..9f7036407 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -2,7 +2,7 @@ # `docker-compose run sdk` will run integration tests using the latest # standalone-node image on dockerhub. The src/ directory is mounted, so rebuilding # is not required to integrate changes in this directory. -# `docker-compose run sdk yarn test:integration:run Attestation` would run specific tests. +# `docker-compose run sdk yarn test:integration:latest-develop Attestation` would run specific tests. # In order to test against the current state of the develop branch, you can build a standalone-node # image locally by telling docker-compose to use the override file `dc.build.node.yml` like so: # `docker-compose -f docker-compose.yml -f dc.build.node.yml run sdk`. Alternatively you could From 485639e7cc6d202e05de877bbd0d22d904ab3699 Mon Sep 17 00:00:00 2001 From: dudleyneedham Date: Fri, 17 May 2024 16:25:58 +0200 Subject: [PATCH 3/3] fix: updating the get started test container --- tests/integration/utils.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/integration/utils.ts b/tests/integration/utils.ts index 6a20a9ffc..ac53cc4a6 100644 --- a/tests/integration/utils.ts +++ b/tests/integration/utils.ts @@ -41,7 +41,7 @@ export async function getStartedTestContainer( process.env.TESTCONTAINERS_NODE_IMG || 'kiltprotocol/standalone-node' console.log(`using testcontainer with image ${image}`) const strategies = [ - ['--dev', '--ws-external', `--ws-port=${WS_PORT}`], + // ['--dev', '--ws-external', `--ws-port=${WS_PORT}`], ['--dev', '--rpc-external', `--rpc-port=${WS_PORT}`], ] // eslint-disable-next-line no-restricted-syntax @@ -61,7 +61,7 @@ export async function getStartedTestContainer( console.log('container started and ready') return started } catch (error) { - console.warn( + throw console.error( 'Failed to start container due to the following error:\n', error )