Skip to content

Non-ASCII characters are not recognized by print_explicit_imports #83

@JoshuaLampert

Description

@JoshuaLampert

Let's say we have the following module in a file Foo.jl:

module Foo
using LinearAlgebra
bar(a, b) = a  b
end

where is exported from LinearAlgebra.jl. Running print_explicit_imports(Foo, "Foo.jl") gives

julia> print_explicit_imports(Foo, "Foo.jl")
  Module Main.Foo is relying on implicit imports for 1 name. This could be explicitly imported as follows:

  using LinearAlgebra: LinearAlgebra

However, exchanging using LinearAlgebra by the suggested using LinearAlgebra: LinearAlgebra breaks the module of course since is not available anymore. I would expect ExplicitImports.jl to suggest using LinearAlgebra: LinearAlgebra, ⋅. I have tested that the same happens with ×. So I assume this happens for non-ASCII characters.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions