Skip to content

base this on AbstractTrees.jl #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nsajko opened this issue May 21, 2024 · 1 comment
Closed

base this on AbstractTrees.jl #32

nsajko opened this issue May 21, 2024 · 1 comment

Comments

@nsajko
Copy link
Contributor

nsajko commented May 21, 2024

It seems like it would make a lot of sense to base this package on the AbstractTrees.jl interface. That is, require users to implement the AbstractTrees.jl interface and any additional functions that are required after that. So some of the functions from this package could be made internal, users wouldn't have to add any methods to those functions. That would enable more interoperability across the ecosystem. Also, TBH, I'm not sure if this package is even necessary given that AbstractTrees.jl already exists?

https://juliahub.com/ui/Packages/General/AbstractTrees

@nsajko
Copy link
Contributor Author

nsajko commented May 26, 2024

Wouldn't work because AbstractTrees.jl can't distinguish between a constant/variable and a nullary expression.

@nsajko nsajko closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant