Skip to content

Commit ff2ee29

Browse files
fix bad inference in isequal_bsimpl
1 parent 0f1e767 commit ff2ee29

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

src/types.jl

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -430,24 +430,18 @@ function isequal_bsimpl(a::BSImpl.Type, b::BSImpl.Type, val)
430430
isequal(f1, f2)::Bool && isequal(args1, args2) && s1 == s2
431431
end
432432
(BSImpl.AddOrMul(; variant = v1, dict = d1, coeff = c1), BSImpl.AddOrMul(; variant = v2, dict = d2, coeff = c2)) => begin
433-
# @show v1 == v2
434-
# @show isequal_symdict(d1, d2, val)
435-
# @show isequal(c1, c2)
436-
v1 == v2 && isequal_symdict(d1, d2, val) && isequal(c1, c2)
433+
v1 == v2 && isequal_symdict(d1, d2, val) && isequal_maybe_scal(c1, c2)
437434
end
438435
(BSImpl.Div(; num = n1, den = d1), BSImpl.Div(; num = n2, den = d2)) => begin
439-
isequal(n1, n2) && isequal(d1, d2)
436+
isequal_maybe_scal(n1, n2) && isequal_maybe_scal(d1, d2)
440437
end
441438
(BSImpl.Pow(; base = n1, exp = d1), BSImpl.Pow(; base = n2, exp = d2)) => begin
442-
isequal(n1, n2) && isequal(d1, d2)
439+
isequal_maybe_scal(n1, n2) && isequal_maybe_scal(d1, d2)
443440
end
444-
_ => throw(UnimplementedForVariantError(isequal_core, Ta))
445441
end
446-
# @show partial, full
447442
if full && partial
448443
partial = isequal(metadata(a), metadata(b))
449444
end
450-
# @show "L"
451445
return partial
452446
end
453447

0 commit comments

Comments
 (0)