Merge pull request #693 from AayushSabharwal/as/number-methods

fix: fix `NaNMath.pow` ambiguity resolution in `@number_methods`

Author: ChrisRackauckas

src/methods.jl

@@ -80,7 +80,7 @@ function number_methods(T, rhs1, rhs2, options=nothing)
 
         # Fix method ambiguity error on NaNMath >= 1.0.2 and promotion of `Integer`s on NaNMath < 1.0.2
         if f === NaNMath.pow
-            push!(exprs, :((f::$(typeof(f)))(a::$T, b::Integer) = ($assert_like(f, Number, a); $term($(^), a, b))))
+            push!(exprs, :((f::$(typeof(f)))(a::$T, b::Integer) = a ^ b))
         end
     end
 

test/code.jl

@@ -106,13 +106,13 @@ nanmath_st.rewrites[:nanmath] = true
 
     @test toexpr(a^-1) == :($(/)(1, a))
     @test toexpr(a^-1, nanmath_st) == :($(/)(1, a))
-    @test toexpr(NaNMath.pow(a, -1)) == :($(inv)(a))
-    @test toexpr(NaNMath.pow(a, -1), nanmath_st) == :($(inv)(a))
+    @test toexpr(NaNMath.pow(a, -1)) == :($(/)(1, a))
+    @test toexpr(NaNMath.pow(a, -1), nanmath_st) == :($(/)(1, a))
 
     @test toexpr(a^-2) == :($(/)(1, $(^)(a, 2)))
     @test toexpr(a^-2, nanmath_st) == :($(/)(1, $(^)(a, 2)))
-    @test toexpr(NaNMath.pow(a, -2)) == :($(^)($(inv)(a), 2))
-    @test toexpr(NaNMath.pow(a, -2), nanmath_st) == :($(^)($(inv)(a), 2))
+    @test toexpr(NaNMath.pow(a, -2)) == :($(/)(1, $(^)(a, 2)))
+    @test toexpr(NaNMath.pow(a, -2), nanmath_st) == :($(/)(1, $(^)(a, 2)))
 
     f = GlobalRef(NaNMath, :sin)
     test_repr(toexpr(LiteralExpr(:(let x=1, y=2