-
-
Notifications
You must be signed in to change notification settings - Fork 45
For fun, I turned on DEBUG... #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
good catch! updated parents have to go directly into |
I looked more deeply into stdlib Logging and it looks like it's gloriously flexible and almost painless with LoggingExtras.jl addons. |
@dalejordan still interested ? |
Better debugging now in #177 |
and I noticed a few minor problems:
@debug "updated parents " id g.parents[id]
inrepair!
generates an exception because g has no parents field (anymore).@debug(n, " not found in memo")
inadd!
has its arguments reversed.I would make a pull request but I'm not sure how to fix the first problem. Still learning how this all works.
I think it might be useful to add some simple statistics gathering about how many adds, merges, etc. are performed;
a less verbose tracing facility than debug would be useful for those wondering how it all really hangs together.
The text was updated successfully, but these errors were encountered: