fix RegexAndMatchData searching (fixes #5)

Author: stevengj

src/regex.jl

@@ -38,9 +38,9 @@ function Base.match(re::Regex, str::DenseStringViewAndSub, idx::Integer, add_opt
     return result
 end
 
-Base.findnext(re::Regex, str::DenseStringViewAndSub, idx::Integer) = _findnext_re(re, str, idx, C_NULL)
+Base.findnext(re::Regex, str::DenseStringViewAndSub, idx::Integer) = Base._findnext_re(re, str, idx, C_NULL)
 
-function _findnext_re(re::Regex, str::DenseStringViewAndSub, idx::Integer, match_data::Ptr{Cvoid})
+function Base._findnext_re(re::Regex, str::DenseStringViewAndSub, idx::Integer, match_data::Ptr{Cvoid})
     if idx > nextind(str,lastindex(str))
         throw(BoundsError())
     end

src/util.jl

@@ -44,8 +44,7 @@ Base.replace(str::DenseStringViewAndSub, pat_repl::Pair{<:Union{Tuple{Vararg{<:A
         count::Integer=typemax(Int)) =
     replace(str, in(first(pat_repl)) => last(pat_repl), count=count)
 
-_pat_replacer(x) = x
-_free_pat_replacer(x) = nothing
+import Base: _pat_replacer, _free_pat_replacer
 
 function Base.replace(str::DenseStringViewAndSub, pat_repl::Pair; count::Integer=typemax(Int))
     pattern, repl = pat_repl

test/runtests.jl

@@ -102,6 +102,12 @@ end
         @test findprev(==("ba"), str, n) === findprev(==("ba"), sS, n)
     end
     @test chomp(StringView("foo\n")) == "foo"
+
+    # issue #5
+    let v = [0x32, 0x30, 0x32, 0x31, 0x2d, 0x31, 0x31, 0x2d, 0x31, 0x30, 0x20, 0x32, 0x31, 0x3a, 0x34, 0x32, 0x3a, 0x30, 0x35, 0x2e, 0x31, 0x31, 0x35, 0x38, 0x30, 0x37],
+        pat = r"(\.[\d]{3})\d+" => s"\g<1>"
+        @test replace(String(copy(v)), pat) == replace(StringView(v), pat)
+    end
 end
 
 @testset "miscellaneous" begin