iteration tests

Author: stevengj

src/decoding.jl

@@ -76,10 +76,7 @@ Base.getindex(s::StringView, r::UnitRange{<:Integer}) = s[Int(first(r)):Int(last
         @inbounds isvalid(s, j) || string_index_err(s, j)
     end
     j = nextind(s, j) - 1
-    n = j - i + 1
-    ss = Base._string_n(n)
-    GC.@preserve s ss unsafe_copyto!(pointer(ss), pointer(s, i), n)
-    return ss
+    return StringView(@view s.data[i:j])
 end
 
 Base.length(s::StringView) = length_continued(s, 1, ncodeunits(s), ncodeunits(s))

test/runtests.jl

@@ -5,6 +5,7 @@ s = StringView(b)
 ss = SubString(s, 2, 5) # "ooba"
 abc = StringView(0x61:0x63)
 invalid = StringView([0x8b, 0x52, 0x9b, 0x8d])
+su = StringView("föôẞαr")
 
 @testset "construction/conversion" begin
     @test StringView(s) === s
@@ -52,6 +53,19 @@ end
     @test isvalid(ss)
 end
 
+@testset "iteration" begin
+    for str in (s, ss, abc, invalid, su)
+        sS = String(str)
+        @test sS == str
+        @test length(sS) == length(str)
+        @test collect(sS) == collect(str) ==
+              getindex.(sS, eachindex(sS)) == getindex.(str, eachindex(sS))
+        @test collect(eachindex(sS)) == collect(eachindex(str))
+        @test sS[1:end] == str[1:end]
+        @test sS[nextind(sS,1):prevind(sS,end)] == str[nextind(str,1):prevind(str,end)]
+    end
+end
+
 @testset "regular expressions" begin
     for str in (s,ss)
         @test [m.match for m in collect(eachmatch(r"[aeiou]+", str))] == ["oo", "a"]