From 53cfe229571ff12dc372af1bb604d695db1ad1d6 Mon Sep 17 00:00:00 2001 From: Kristoffer Date: Fri, 12 Jul 2024 11:15:42 +0200 Subject: [PATCH 1/2] remove some unnecessary `string` overloads --- src/InlineStrings.jl | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/InlineStrings.jl b/src/InlineStrings.jl index 6a107f1..e238637 100644 --- a/src/InlineStrings.jl +++ b/src/InlineStrings.jl @@ -613,13 +613,11 @@ end return n end -const BaseStrs = Union{Char, String, SubString{String}} + Base.string(a::InlineString) = a Base.string(a::InlineString...) = _string(a...) -Base.string(a::BaseStrs, b::InlineString) = _string(a, b) -Base.string(a::BaseStrs, b::BaseStrs, c::InlineString) = _string(a, b, c) -@inline function _string(a::Union{BaseStrs, InlineString}...) +@inline function _string(a::InlineString...) n = 0 for v in a if v isa Char From f2e9c94a5c97f46ec700220c34f0463797116c0f Mon Sep 17 00:00:00 2001 From: Kristoffer Carlsson Date: Fri, 12 Jul 2024 15:23:53 +0200 Subject: [PATCH 2/2] test updating invalidation script --- .github/workflows/Invalidations.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/Invalidations.yml b/.github/workflows/Invalidations.yml index 4d0004e..040573b 100644 --- a/.github/workflows/Invalidations.yml +++ b/.github/workflows/Invalidations.yml @@ -30,11 +30,13 @@ jobs: - uses: julia-actions/julia-buildpkg@v1 - uses: julia-actions/julia-invalidations@v1 id: invs_default - + - name: Report invalidation counts run: | echo "Invalidations on default branch: ${{ steps.invs_default.outputs.total }} (${{ steps.invs_default.outputs.deps }} via deps)" >> $GITHUB_STEP_SUMMARY echo "This branch: ${{ steps.invs_pr.outputs.total }} (${{ steps.invs_pr.outputs.deps }} via deps)" >> $GITHUB_STEP_SUMMARY - name: Check if the PR does increase number of invalidations - if: steps.invs_pr.outputs.total > steps.invs_default.outputs.total - run: exit 1 + run: | + if [ ${{ steps.invs_pr.outputs.total }} -gt ${{ steps.invs_default.outputs.total }} ]; then + exit 1 + fi