Skip to content

Commit 2a2cfaa

Browse files
committed
Fix truncated normal MGF implementation
1 parent 861971b commit 2a2cfaa

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/truncated/normal.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,11 @@ function mgf(d::Truncated{Normal{T},Continuous}, t::Real) where {T}
122122
d0 = d.untruncated
123123
μ = mean(d0)
124124
σ = std(d0)
125-
σt = σ * t
126-
a = (minimum(d) - μ) / σ - σt
127-
b = (maximum(d) - μ) / σ - σt
125+
σ²t = σ^2 * t
126+
a = (minimum(d) - μ) / σ - σ²t
127+
b = (maximum(d) - μ) / σ - σ²t
128128
stdnorm = Normal{T}(zero(T), one(T))
129-
return exp(μ * t + σt^2 / 2 + logdiffcdf(d0, b, a) - d.logtp)
129+
return exp(t * + σ²t / 2) + logdiffcdf(stdnorm, b, a) - d.logtp)
130130
end
131131

132132
### sampling

0 commit comments

Comments
 (0)