Skip to content

Review verbNoun of solveKey #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dehann opened this issue Jul 11, 2024 · 2 comments
Open

Review verbNoun of solveKey #1083

dehann opened this issue Jul 11, 2024 · 2 comments
Labels
design supersolve
Milestone
v0.0.x

Comments

@dehann
Copy link
Member

dehann commented Jul 11, 2024 •
edited
Loading

  • Why key not label?
  • standardize function signatures for consistent invocation of argument or keyword argument solveKey
@dehann dehann added this to the v0.0.x milestone Jul 11, 2024
@Affie
Copy link
Member

Affie commented Oct 21, 2024

We should also look at when the solveKey parameter is used as argument vs keyword argument.

@Affie
Copy link
Member

Affie commented Jun 11, 2025

We discussed this and decided to use label for consistency.
The replacement for solveKey will be stateLabel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design supersolve
Projects
None yet
Milestone
v0.0.x
Development

No branches or pull requests
2 participants
@dehann @Affie