Skip to content

Commit dbfb24e

Browse files
committed
Small fixes/tweaks [ci skip]
1 parent be5cc4a commit dbfb24e

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ julia> using Pkg # for julia ≥ 0.7
2424
julia> Pkg.add("PyCall")
2525
```
2626

27-
Your python installation must be able to call Julia. If your installer
28-
does not add the Julia binary directory to your `PATH`, you will have to
29-
add it. _An alias will not work._
27+
Your python installation must be able to call command line program
28+
`julia`. If your installer does not add the Julia binary directory to
29+
your `PATH`, you will have to add it. _An alias will not work._
3030

3131
Then finally you have to install PyJulia.
3232

@@ -51,7 +51,7 @@ install PyJulia directly from GitHub:
5151
$ python3 -m pip install --user 'https://github.com/JuliaPy/pyjulia/archive/master.zip#egg=julia'
5252
```
5353

54-
You may clone it directly to your home directory.
54+
You may clone it directly to (say) your home directory.
5555

5656
```console
5757
$ git clone https://github.com/JuliaPy/pyjulia
@@ -97,7 +97,7 @@ Other variants of Python import syntax also work:
9797

9898
```pycon
9999
>>> import julia.Base
100-
>>> from julia.Base import LinAlg # import a submodule
100+
>>> from julia.Base import Enums # import a submodule
101101
>>> from julia.Base import sin # import a function from a module
102102
```
103103

@@ -293,7 +293,7 @@ example, the Julia method `sum!` can be called in PyJulia using
293293
There was a major overhaul in the module loading system between Julia
294294
0.6 and 1.0. As a result,
295295
[the hack](https://github.com/JuliaPy/pyjulia/tree/master/julia/fake-julia)
296-
supporting the PyJulia to load PyCall.
296+
supporting the PyJulia to load PyCall stopped working.
297297

298298
To understand the issue, you need to understand a bit of details in
299299
PyCall implementation. PyCall uses Julia's precompilation mechanism
@@ -304,8 +304,8 @@ layout varies across Python versions. Currently, this is determined
304304
while precompiling PyJulia and cannot be changed at run-time.
305305
Consequently, PyCall only works if it loads the same libpython in
306306
Julia and Python. This is why PyJulia has to be imported in a Python
307-
executable dynamically linked to libpython when using the same PyCall
308-
precompilation cache.
307+
executable dynamically linked to libpython, if it shares the same
308+
PyCall precompilation cache.
309309

310310
The aforementioned hack worked by monkey-patching Julia's
311311
precompilation mechanism to emit the precompilation cache file to

0 commit comments

Comments
 (0)