Skip to content

Commit 012ca19

Browse files
committed
Remove some completed TODO comments
1 parent 3cb9912 commit 012ca19

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

array_api_tests/test_linalg.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
required, but we don't yet have a clean way to disable only those tests (see https://github.com/data-apis/array-api-tests/issues/25).
1313
1414
"""
15-
# TODO: test with complex dtypes where appropiate
15+
# TODO: test with complex dtypes where appropriate
1616

1717
import pytest
1818
from hypothesis import assume, given
@@ -558,9 +558,6 @@ def _x2_shapes(draw):
558558
def test_solve(x1, x2):
559559
res = linalg.solve(x1, x2)
560560

561-
# TODO: This requires an upstream fix to ndindex
562-
# (https://github.com/Quansight-Labs/ndindex/pull/131)
563-
564561
if x2.ndim == 1:
565562
_test_stacks(linalg.solve, x1, x2, res=res, dims=1,
566563
matrix_axes=[(-2, -1), (0,)], res_axes=[-1])
@@ -714,7 +711,6 @@ def _test_tensordot_stacks(x1, x2, kw, res):
714711
tensordot_kw,
715712
)
716713
def test_tensordot(x1, x2, kw):
717-
# TODO: vary shapes, vary contracted axes, test different axes arguments
718714
res = xp.tensordot(x1, x2, **kw)
719715

720716
ph.assert_dtype("tensordot", in_dtype=[x1.dtype, x2.dtype],
@@ -734,7 +730,6 @@ def test_tensordot(x1, x2, kw):
734730
result_shape = _shape1 + _shape2
735731
ph.assert_result_shape('tensordot', [x1.shape, x2.shape], res.shape,
736732
expected=result_shape)
737-
# TODO: assert stacking and elements
738733
_test_tensordot_stacks(x1, x2, kw, res)
739734

740735
@pytest.mark.xp_extension('linalg')
@@ -781,7 +776,6 @@ def true_trace(x_stack, offset=0):
781776
data(),
782777
)
783778
def test_vecdot(x1, x2, data):
784-
# TODO: vary shapes, test different axis arguments
785779
broadcasted_shape = sh.broadcast_shapes(x1.shape, x2.shape)
786780
min_ndim = min(x1.ndim, x2.ndim)
787781
ndim = len(broadcasted_shape)

0 commit comments

Comments
 (0)