Skip to content

Commit ea0a86d

Browse files
authored
ci fixes (#401)
1 parent dd00189 commit ea0a86d

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

.codecov.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
comment: false
2+
coverage:
3+
status:
4+
project: false
5+
patch: false
6+
7+
# docs.codecov.com/docs/github-checks#disabling-github-checks-patch-annotations
8+
github_checks:
9+
annotations: false

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
fail-fast: false
1919
matrix:
2020
version:
21-
- '1.10' # oldest supported LTS (declared in Project.toml)
21+
- 'lts' # oldest compatible version declared in Project.toml
2222
- '1'
2323
experimental:
2424
- false

test/runtests.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ test_ref(reference, actual) = @test_reference(
3939
)
4040

4141
is_ci() = Base.get_bool_env("CI", false)
42+
is_pkgeval() = Base.get_bool_env("JULIA_PKGEVAL", false)
4243

4344
# helpers
4445

test/tst_io.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ sombrero(x, y) = 30sinc(√(x^2 + y^2) / π)
6161
@testset "stringify plot - performance regression" begin
6262
nightly = occursin("DEV", string(VERSION)) # or length(VERSION.prerelease) < 2
6363
measure = Sys.islinux() && VERSION > v"1.10.0-" && !nightly
64+
margin = is_pkgeval() ? 5 : 1 # apply a perf coefficient for slow runners
6465

6566
let p = heatmap(collect(1:30) * collect(1:30)')
6667
@test string(p; color = true) isa String # 1st pass - ttfp
@@ -69,7 +70,7 @@ sombrero(x, y) = 30sinc(√(x^2 + y^2) / π)
6970
GC.enable(false)
7071
stats = @timed string(p; color = true) # repeated !
7172
@test stats.bytes / 1e3 < 500 # ~ 292kB on 1.11
72-
@test stats.time * 1e3 < 0.8 # ~ 0.3ms on 1.11
73+
@test stats.time * 1e3 < margin * 0.8 # ~ 0.3ms on 1.11
7374
GC.enable(true)
7475
end
7576
end
@@ -81,7 +82,7 @@ sombrero(x, y) = 30sinc(√(x^2 + y^2) / π)
8182
GC.enable(false)
8283
stats = @timed string(p; color = true) # repeated !
8384
@test stats.bytes / 1e3 < 160 # ~ 123kB on 1.11
84-
@test stats.time * 1e3 < 0.5 # ~ 0.2ms on 1.11
85+
@test stats.time * 1e3 < margin * 0.5 # ~ 0.2ms on 1.11
8586
GC.enable(true)
8687
end
8788
end

0 commit comments

Comments
 (0)