Add specialised type handling for vector of vectors #5101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into test failures at the moment |
|
Please be aware that the |
|
Thanks @t-bltg - I saw that was happening, but wasn't sure whether it was at a stage to go straight onto v2. I'll regenerate the PR for v2 instead then. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5101 +/- ##
==========================================
+ Coverage 89.77% 89.83% +0.06%
==========================================
Files 40 40
Lines 8780 8852 +72
==========================================
+ Hits 7882 7952 +70
- Misses 898 900 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just getting myself familiar with the
Plots.jllibrary and so thought I would try and fix some of the outstanding bugs to help me with that.This looks to fix #4777 by introducing a specialisation for vector of vectors, applying recipes in a similar fashion to the
AbstractArrayhandling.Added unit testing to verify behaviour within the bug works. Have also tested manually that consistent behaviour applies for array type recipes (https://docs.juliaplots.org/stable/gallery/gr/generated/gr-ref045/).