Skip to content

Commit 8882291

Browse files
authored
temporarily disable broken example (#5106)
1 parent 345ed61 commit 8882291

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

PlotsBase/test/runtests.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,12 @@ using FileIO
4848
using Dates
4949
using Test
5050

51+
const broken_examples = Int[] # NOTE: unexpected pass is a failure
52+
Sys.isapple() && push!(broken_examples, 50) # FIXME: https://github.com/jheinen/GR.jl/issues/550
53+
54+
const skipped_examples = Int[] # NOTE: won't error, regardless of the test output
55+
push!(skipped_examples, 62) # TODO: remove when new GR release is out and lands through CI (compat issues)
56+
5157
function available_channels()
5258
juliaup = "https://julialang-s3.julialang.org/juliaup"
5359
for i 1:6
@@ -89,12 +95,6 @@ is_ci() || @eval using Gtk # see JuliaPlots/VisualRegressionTests.jl/issues/30
8995

9096
ref_name(i) = "ref" * lpad(i, 3, '0')
9197

92-
const broken_examples = if Sys.isapple()
93-
[50] # FIXME: https://github.com/jheinen/GR.jl/issues/550
94-
else
95-
[]
96-
end
97-
9898
# skip the majority of tests if we only want to update reference images or under `PkgEval` (timeout limit)
9999
names = if is_auto()
100100
["reference"]

PlotsBase/test/test_backends.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ is_pkgeval() || @testset "Backends" begin
6666
@test filesize(fn) > 1_000
6767
end
6868
(Sys.islinux() && is_latest("release")) && for be TEST_BACKENDS
69-
skip = vcat(PlotsBase._backend_skips[be], broken_examples)
69+
skip = vcat(PlotsBase._backend_skips[be], skipped_examples, broken_examples)
7070
PlotsBase.test_examples(be; skip, callback, disp = is_ci(), strict = true) # `ci` display for coverage
7171
closeall()
7272
end

PlotsBase/test/test_reference.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ end
151151
image_comparison_facts(
152152
:gr,
153153
tol = PLOTSBASE_IMG_TOL,
154-
skip = vcat(PlotsBase._backend_skips[:gr]),
154+
skip = vcat(PlotsBase._backend_skips[:gr], skipped_examples),
155155
broken = broken_examples,
156156
)
157157
end

0 commit comments

Comments
 (0)