Merge pull request #413 from JuliaParallel/jps/ci-commands

TEST: Try implementing custom actions

Author: jpsamaroo

.github/workflows/CustomCommands.yml

@@ -0,0 +1,46 @@
+name: Custom Commands
+
+on:
+  pull_request:
+
+jobs:
+  custom_actions:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Wait for commands
+        id: read_commands
+        run: |
+          while true; do
+            ci_commands=$(curl -sH "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -X GET "${{ github.event.pull_request.comments_url }}" | jq -r ".[] | select(.body | startswith(\"/run-actions\")) | .body")
+            if [ ! -z "$ci_commands" ]; then
+              echo "Read commands $ci_commands"
+              echo "ci_commands=$ci_commands" >> $GITHUB_OUTPUT
+              break
+            fi
+            sleep 30
+          done
+
+      - uses: actions/checkout@v2
+      - uses: julia-actions/setup-julia@v1
+        with:
+          version: '1.9'
+          arch: 'x64'
+
+      - name: Run provided commands
+        run: |
+          echo "Got custom commands:"
+          ci_commands="${{ steps.read_commands.outputs.ci_commands }}"
+          echo $ci_commands
+          if echo "$ci_commands" | grep -q benchmark; then
+            echo "Running benchmarks..."
+            julia -e 'using Pkg; Pkg.add("BenchmarkTools"); Pkg.develop(;path=pwd())'
+            JULIA_PROJECT=$PWD julia --project benchmarks/benchmark.jl
+          fi
+          if echo "$ci_commands" | grep -q premerge; then
+            echo "Running pre-merge checks..."
+            julia -e 'using Pkg; Pkg.add("Aqua"); Pkg.develop(;path=pwd())'
+            JULIA_PROJECT=$PWD julia --project -e 'using Aqua, Dagger; Aqua.test_all(Dagger)'
+          fi
+        env:
+          BENCHMARK: "nmf:raw,dagger"
+          BENCHMARK_SCALE: "5:5:10"

benchmarks/suites/nmf.jl

@@ -55,40 +55,43 @@ function nmf_suite(ctx; method, accels)
             nw = length(workers())
             nsuite = BenchmarkGroup()
             while nw > 0
-                opts = if accel == "cuda"
+                scope = if accel == "cuda"
+                    error("Not implemented")
                     Dagger.Sch.SchedulerOptions(;proctypes=[
                         DaggerGPU.CuArrayDeviceProc
                     ])
                 elseif accel == "amdgpu"
+                    error("Not implemented")
                     Dagger.Sch.SchedulerOptions(;proctypes=[
                         DaggerGPU.ROCArrayProc
                     ])
                 elseif accel == "cpu"
-                    Dagger.Sch.SchedulerOptions()
+                    scope = Dagger.scope(;workers=workers()[1:nw])
                 else
                     error("Unknown accelerator $accel")
                 end
                 #bsz = ncol ÷ length(workers())
                 bsz = ncol ÷ 64
                 nsuite["Workers: $nw"] = @benchmarkable begin
-                    _ctx = Context($ctx, workers()[1:$nw])
-                    compute(_ctx, nnmf($X[], $W[], $H[]); options=$opts)
+                    Dagger.with_options(;scope=$scope) do
+                        fetch(nnmf($X[], $W[], $H[]))
+                    end
                 end setup=begin
                     _nw, _scale = $nw, $scale
                     @info "Starting $_nw worker Dagger NNMF (scale by $_scale)"
                     if $accel == "cuda"
                         # FIXME: Allocate with CUDA.rand if possible
-                        $X[] = Dagger.mapchunks(CUDA.cu, compute(rand(Blocks($bsz, $bsz), Float32, $nrow, $ncol); options=$opts))
-                        $W[] = Dagger.mapchunks(CUDA.cu, compute(rand(Blocks($bsz, $bsz), Float32, $nrow, $nfeatures); options=$opts))
-                        $H[] = Dagger.mapchunks(CUDA.cu, compute(rand(Blocks($bsz, $bsz), Float32, $nfeatures, $ncol); options=$opts))
+                        $X[] = Dagger.mapchunks(CuArray, rand(Blocks($bsz, $bsz), Float32, $nrow, $ncol))
+                        $W[] = Dagger.mapchunks(CuArray, rand(Blocks($bsz, $bsz), Float32, $nrow, $nfeatures))
+                        $H[] = Dagger.mapchunks(CuArray, rand(Blocks($bsz, $bsz), Float32, $nfeatures, $ncol))
                     elseif $accel == "amdgpu"
-                        $X[] = Dagger.mapchunks(ROCArray, compute(rand(Blocks($bsz, $bsz), Float32, $nrow, $ncol); options=$opts))
-                        $W[] = Dagger.mapchunks(ROCArray, compute(rand(Blocks($bsz, $bsz), Float32, $nrow, $nfeatures); options=$opts))
-                        $H[] = Dagger.mapchunks(ROCArray, compute(rand(Blocks($bsz, $bsz), Float32, $nfeatures, $ncol); options=$opts))
+                        $X[] = Dagger.mapchunks(ROCArray, rand(Blocks($bsz, $bsz), Float32, $nrow, $ncol))
+                        $W[] = Dagger.mapchunks(ROCArray, rand(Blocks($bsz, $bsz), Float32, $nrow, $nfeatures))
+                        $H[] = Dagger.mapchunks(ROCArray, rand(Blocks($bsz, $bsz), Float32, $nfeatures, $ncol))
                     elseif $accel == "cpu"
-                        $X[] = compute(rand(Blocks($bsz, $bsz), Float32, $nrow, $ncol); options=$opts)
-                        $W[] = compute(rand(Blocks($bsz, $bsz), Float32, $nrow, $nfeatures); options=$opts)
-                        $H[] = compute(rand(Blocks($bsz, $bsz), Float32, $nfeatures, $ncol); options=$opts)
+                        $X[] = rand(Blocks($bsz, $bsz), Float32, $nrow, $ncol)
+                        $W[] = rand(Blocks($bsz, $bsz), Float32, $nrow, $nfeatures)
+                        $H[] = rand(Blocks($bsz, $bsz), Float32, $nfeatures, $ncol)
                     end
                 end teardown=begin
                     if render != "" && !live