BREAKING: Remove the LSF functionality from this package (and point users to JuliaParallel/LSFClusterManagers.jl instead) (#237)

* BREAKING: Remove the LSF functionality from this package (and point users to `LSFClusterManagers.jl` instead)

* Bump version from `0.4.9` to `1.0.0-DEV` (because this PR is a breaking change)

Author: DilumAluthge

Project.toml

@@ -1,6 +1,6 @@
 name = "ClusterManagers"
 uuid = "34f1f09b-3a8b-5176-ab39-66d58a4d544e"
-version = "0.4.9"
+version = "1.0.0-DEV"
 
 [deps]
 Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"

README.md

@@ -15,7 +15,6 @@ Implemented in this package (the `ClusterManagers.jl` package):
 
 | Job queue system | Command to add processors |
 | ---------------- | ------------------------- |
-| Load Sharing Facility (LSF) | `addprocs_lsf(np::Integer; bsub_flags=``, ssh_cmd=``)` or `addprocs(LSFManager(np, bsub_flags, ssh_cmd, retry_delays, throttle))` |
 | Sun Grid Engine (SGE) via `qsub` | `addprocs_sge(np::Integer; qsub_flags=``)` or `addprocs(SGEManager(np, qsub_flags))` |
 | Sun Grid Engine (SGE) via `qrsh` | `addprocs_qrsh(np::Integer; qsub_flags=``)` or `addprocs(QRSHManager(np, qsub_flags))` |
 | PBS (Portable Batch System) | `addprocs_pbs(np::Integer; qsub_flags=``)` or `addprocs(PBSManager(np, qsub_flags))` |
@@ -30,6 +29,7 @@ Implemented in external packages:
 
 | Job queue system | Command to add processors |
 | ---------------- | ------------------------- |
+| Load Sharing Facility (LSF) via [LSFClusterManager.jl](https://github.com/JuliaParallel/LSFClusterManager.jl) | `addprocs_lsf(np::Integer; bsub_flags=``, ssh_cmd=``)` or `addprocs(LSFManager(np, bsub_flags, ssh_cmd, retry_delays, throttle))` |
 | Kubernetes (K8s) via [K8sClusterManagers.jl](https://github.com/beacon-biosignals/K8sClusterManagers.jl) | `addprocs(K8sClusterManager(np; kwargs...))` |
 | Azure scale-sets via [AzManagers.jl](https://github.com/ChevronETC/AzManagers.jl) | `addprocs(vmtemplate, n; kwargs...)` |
 
@@ -132,11 +132,6 @@ Julia workers can frequently timeout waiting for the standard output files to ap
 In this case, it's better to use the `QRSHManager`, which uses SGE's `qrsh`
 command to bypass the filesystem and captures STDOUT directly.
 
-### Load Sharing Facility (LSF)
-
-`LSFManager` supports IBM's scheduler.  See the `addprocs_lsf` docstring
-for more information.
-
 ### Using `LocalAffinityManager` (for pinning local workers to specific cores)
 
 - Linux only feature.

src/ClusterManagers.jl

@@ -19,6 +19,5 @@ include("condor.jl")
 include("slurm.jl")
 include("affinity.jl")
 include("elastic.jl")
-include("lsf.jl")
 
 end

src/lsf.jl

@@ -13,8 +13,6 @@ using Test: @testset, @test, @test_skip
 using ClusterManagers: ElasticManager
 # Slurm:
 using ClusterManagers: addprocs_slurm, SlurmManager
-# LSF:
-using ClusterManagers: addprocs_lsf, LSFManager
 # SGE:
 using ClusterManagers: addprocs_sge, SGEManager
 
@@ -23,7 +21,6 @@ const test_args = lowercase.(strip.(ARGS))
 @info "" test_args
 
 slurm_is_installed() = !isnothing(Sys.which("sbatch"))
-lsf_is_installed() = !isnothing(Sys.which("bsub"))
 qsub_is_installed() = !isnothing(Sys.which("qsub"))
 
 @testset "ClusterManagers.jl" begin
@@ -42,19 +39,6 @@ qsub_is_installed() = !isnothing(Sys.which("qsub"))
         end
     end
 
-    if lsf_is_installed()
-        @info "Running the LSF tests..." Sys.which("bsub")
-        include("lsf.jl")
-    else
-        if "lsf" in test_args
-            @error "ERROR: The LSF tests were explicitly requested in ARGS, but bsub was not found, so the LSF tests cannot be run" Sys.which("bsub") test_args
-            @test false
-        else
-            @warn "bsub was not found - LSF tests will be skipped" Sys.which("bsub")
-            @test_skip false
-        end
-    end
-
     if qsub_is_installed()
         @info "Running the SGE (via qsub) tests..." Sys.which("qsub")
         include("slurm.jl")