Skip to content

Commit ac99aa5

Browse files
authored
More accurate condition for broken test (#348)
1 parent ebaf506 commit ac99aa5

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/runners.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,9 +443,10 @@ end
443443
set -e
444444
make -j${nproc} -sC /usr/share/testsuite install
445445
"""
446-
# This test fails on GitHub Actions with non-squashfs:
446+
# This test fails on GitHub Actions with non-squashfs on UserNS runners:
447447
# <https://github.com/JuliaPackaging/BinaryBuilderBase.jl/issues/347>.
448-
@test run(ur, `/bin/bash -c "$(test_script)"`, iobuff) broken=(get(ENV, "GITHUB_ACTIONS", "false")=="true" && !(BinaryBuilderBase.use_squashfs[]))
448+
is_broken = get(ENV, "GITHUB_ACTIONS", "false")=="true" && !(BinaryBuilderBase.use_squashfs[]) && BinaryBuilderBase.preferred_runner() == BinaryBuilderBase.UserNSRunner
449+
@test run(ur, `/bin/bash -c "$(test_script)"`, iobuff) broken=is_broken
449450
end
450451
end
451452
end

0 commit comments

Comments
 (0)