[Wizard] Provide a way to to cancel the provision of URL for additional sources (#1100)

* Option to leave URL loop

* Update src/wizard/obtain_source.jl

* adding tests

* Fix Tests

* Remove deps

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

Author: gbaraldi

src/wizard/obtain_source.jl

@@ -99,10 +99,12 @@ function download_source(state::WizardState)
         # First, ask the user where this is all coming from
         msg = replace(strip("""
         Please enter a URL (git repository or compressed archive) containing the
-        source code to build:
+        source code to build or `N` to stop:
         """), "\n" => " ")
         new_entered_url = nonempty_line_prompt("URL", msg; ins=state.ins, outs=state.outs)
-
+        if new_entered_url == "N" || new_entered_url == "n"
+            return new_entered_url, SetupSource(string(new_entered_url), "", "", "")
+        end
         # Early-exit for invalid URLs, using HTTP.URIs.parse_uri() to ensure
         # it is a valid URL
         try
@@ -115,7 +117,6 @@ function download_source(state::WizardState)
             continue
         end
     end
-
     # Did the user exit out with ^D or something else go horribly wrong?
     if entered_url === nothing
         error("Could not obtain source URL")
@@ -325,10 +326,16 @@ function obtain_source(state::WizardState)
 
     while true
         url, file = download_source(state)
-        push!(state.source_urls, url)
-        push!(state.source_files, file)
-        println(state.outs)
-
+        if url != "N"
+            push!(state.source_urls, url)
+            push!(state.source_files, file)
+            println(state.outs)
+        else
+            if isempty(state.source_urls)
+                printstyled(state.outs, "No URLs were given.\n", color=:yellow, bold=true)
+                continue
+            end
+        end 
         q = "Would you like to download additional sources? "
         if yn_prompt(state, q, :n) != :y
             break

test/wizard.jl

@@ -251,6 +251,30 @@ end
     @test length(state.dependencies) == 2
     @test any([BinaryBuilder.getname(d) == "ghr_jll" for d in state.dependencies])
     @test any([BinaryBuilder.getname(d) == "Zlib_jll" for d in state.dependencies])
+
+    # Test for escaping the URL prompt with N
+    state = step2_state()
+    with_wizard_output(state, Wizard.step2) do ins, outs
+        call_response(ins, outs, "Please enter a URL", "http://127.0.0.1:$(port)/a/source.tar.gz")
+        call_response(ins, outs, "Would you like to download additional sources", "Y")
+        call_response(ins, outs, "Please enter a URL", "N")
+        call_response(ins, outs, "Would you like to download additional sources", "N")
+        call_response(ins, outs, "Do you require any (binary) dependencies", "N")
+        call_response(ins, outs, "Enter a name for this project", "get_me_out")
+        call_response(ins, outs, "Enter a version number", "1.0.0")
+        call_response(ins, outs, "Do you want to customize the set of compilers?", "N")
+    end
+    @test state.source_urls == ["http://127.0.0.1:$(port)/a/source.tar.gz"]
+    state = step2_state()   
+    with_wizard_output(state, Wizard.step2) do ins, outs
+        call_response(ins, outs, "Please enter a URL", "N")
+        call_response(ins, outs, "No URLs", "http://127.0.0.1:$(port)/a/source.tar.gz")
+        call_response(ins, outs, "Would you like to download additional sources", "N")
+        call_response(ins, outs, "Do you require any (binary) dependencies", "N")
+        call_response(ins, outs, "Enter a name for this project", "no_urls")
+        call_response(ins, outs, "Enter a version number", "1.0.0")
+        call_response(ins, outs, "Do you want to customize the set of compilers?", "N")
+    end
 end