modify check for existing files that properly splits name and extension (#1094)

* modify check for existing files that properly splits name and extension for files with multiple extension parts like .tar.gz

* apply review suggestion

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

* add a test for file extensions

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

Author: Crghilardi

src/wizard/obtain_source.jl

@@ -161,7 +161,13 @@ function download_source(state::WizardState)
         source_path = joinpath(state.workspace, basename(url))
 
         if isfile(source_path)
-            name, ext = splitext(basename(source_path))
+            # Try to match everything up to but not including ".tar.*" to strip multiple file extensions
+            m = match(r"^.+(?=(\.tar\.([\s\S]+)))", basename(source_path))
+            name, ext = if isnothing(m)
+                splitext(basename(source_path))
+            else
+                m.match, m.captures[1]
+            end
             n = 1
             while isfile(joinpath(state.workspace, "$(name)_$n$ext"))
                 n += 1

test/wizard.jl

@@ -206,6 +206,12 @@ end
         libfoo_tarball_hash,
     ]
 
+    #test that two files downloaded with the same name are re-named appropriately 
+    m = match.(r"^.+(?=(\.tar\.([\s\S]+)))", basename.(getfield.(state.source_files,:path)))
+    for cap in m
+        @test cap.captures[1] ∈ BinaryBuilderBase.tar_extensions
+    end
+
     # Test download/install with a broken symlink that used to kill the wizard
     # https://github.com/JuliaPackaging/BinaryBuilder.jl/issues/183
     state = step2_state()