Update tests accordingly

Author: andrewjradcliffe

test/e_lgamma_r.jl

@@ -1,43 +1,42 @@
 # From openlibm/test/libm-test-ulps.h, openlibm/test/libm-test.c
 
-using SpecialFunctions: _lgamma_r, _lgammaf_r
-
 # lgamma_test block
-for (T, lgamma) in ((Float64, _lgamma_r), (Float32, _lgammaf_r))
+# for (T, lgamma) in ((Float64, _lgamma_r), (Float32, _lgammaf_r))
+for T in (Float64, Float32)
     @testset "lgamma_test, $T" begin
-        @test lgamma(T(Inf))[1] === T(Inf)
-        @test lgamma(T(0))[1] === T(Inf)
-        @test lgamma(T(NaN))[1] === T(NaN)
+        @test logabsgamma(T(Inf))[1] === T(Inf)
+        @test logabsgamma(T(0))[1] === T(Inf)
+        @test logabsgamma(T(NaN))[1] === T(NaN)
 
-        @test lgamma(T(-3))[1] === T(Inf)
-        @test lgamma(T(-Inf))[1] === T(Inf)
+        @test logabsgamma(T(-3))[1] === T(Inf)
+        @test logabsgamma(T(-Inf))[1] === T(Inf)
 
-        # lgamma(1) == 0, lgamma (1) sets signgam to 1
-        y, signgam = labsgamma(T(1))
+        # logabsgamma(1) == 0, lgamma (1) sets signgam to 1
+        y, signgam = logabsgamma(T(1))
         @test y === T(0.0)
         @test signgam == 1
 
-        # lgamma(3) == log(2), lgamma (3) sets signgam to 1
-        y, signgam = labsgamma(T(3))
+        # logabsgamma(3) == log(2), lgamma (3) sets signgam to 1
+        y, signgam = logabsgamma(T(3))
         @test y === log(T(2.0))
         @test signgam == 1
 
-        # lgamma(0.5) == log(sqrt(pi)), lgamma(0.5) sets signgam to 1
-        y, signgam = labsgamma(T(0.5))
+        # logabsgamma(0.5) == log(sqrt(pi)), logabsgamma(0.5) sets signgam to 1
+        y, signgam = logabsgamma(T(0.5))
         @test y === T(0.5log(π))
         @test signgam == 1
 
-        # lgamma(-0.5) == log(2sqrt(pi)), lgamma(-0.5) sets signgam to -1
-        y, signgam = labsgamma(T(-0.5))
+        # logabsgamma(-0.5) == log(2sqrt(pi)), logabsgamma(-0.5) sets signgam to -1
+        y, signgam = logabsgamma(T(-0.5))
         @test y === T(0.5log(4π))
         @test signgam == -1
 
         # In the two "broken" tests, an exact match not possible, even
         # in Float64, thus, we check for as close a tolerance as
         # possible.
 
-        # lgamma(0.7) == 0.26086724653166651439, lgamma(0.7) sets signgam to 1
-        y, signgam = labsgamma(T(0.7))
+        # logabsgamma(0.7) == 0.26086724653166651439, logabsgamma(0.7) sets signgam to 1
+        y, signgam = logabsgamma(T(0.7))
         # @test_broken y === 0.26086724653166651439
         if T === Float64
             @test y ≈ 0.26086724653166651439 atol=6e-17
@@ -46,8 +45,8 @@ for (T, lgamma) in ((Float64, _lgamma_r), (Float32, _lgammaf_r))
         end
         @test signgam == 1
 
-        # lgamma(1.2) == -0.853740900033158497197e-1, lgamma(1.2) sets signgam to 1
-        y, signgam = labsgamma(T(1.2))
+        # logabsgamma(1.2) == -0.853740900033158497197e-1, logabsgamma(1.2) sets signgam to 1
+        y, signgam = logabsgamma(T(1.2))
         # @test_broken y === -0.853740900033158497197e-1
         if T === Float64
             @test y ≈ -0.853740900033158497197e-1 atol=2e-17
@@ -72,9 +71,7 @@ function openlibm_logabsgamma(x::Float32)
     return y, Int(signp[])
 end
 
-meetstol(x::Float64, atol) = isapprox(openlibm_logabsgamma(x)[1], _lgamma_r(x)[1], atol=atol)
-meetstol(x::Float32, atol) = isapprox(openlibm_logabsgamma(x)[1], _lgammaf_r(x)[1], atol=atol)
-
+meetstol(x, atol) = isapprox(openlibm_logabsgamma(x)[1], logabsgamma(x)[1], atol=atol)
 
 @testset "logabsgamma validation against OpenLibm, Float64" begin
     @test all(x -> meetstol(x, 1e-13), -50:1e-4:50)