Skip to content

Commit fdff565

Browse files
committed
Add TODO for to drop one-arg div,fld,etc after 2.0
1 parent 2eb9378 commit fdff565

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/FixedPointDecimals.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,8 @@ end
300300
for remfn in [:rem, :mod, :mod1, :min, :max]
301301
@eval $remfn(x::T, y::T) where {T <: FD} = reinterpret(T, $remfn(x.i, y.i))
302302
end
303+
# TODO: When we upgrade to a min julia version >=1.4 (i.e Julia 2.0), this block can be
304+
# dropped in favor of three-argument `div`, below.
303305
for divfn in [:div, :fld, :fld1, :cld]
304306
# div(x.i, y.i) eliminates the scaling coefficient, so we call the FD constructor.
305307
# We don't need any widening logic, since we won't be multiplying by the coefficient.

0 commit comments

Comments
 (0)