Skip to content

Commit 8d6712f

Browse files
committed
Don't divide by N when judging two commits to prevent noisiness
1 parent a258785 commit 8d6712f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

benchmark/runbench.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,11 @@ function runbench()
4747
export_markdown(joinpath(@__DIR__, "results.md"), bench_results)
4848
end
4949

50+
# For judging the difference between two commits, we don't need to divide by N. Keeping the
51+
# numbers larger like this helps the signal-to-noise ratio for comparing small changes.
5052
function judgebench(target::Union{String, BenchmarkConfig}, baseline::Union{String, BenchmarkConfig})
5153
bench_results = withenv("BENCH_NUM_ITERS"=>string(N)) do
52-
judge("FixedPointDecimals", target, baseline; f=identity, postprocess=postprocess)
54+
judge("FixedPointDecimals", target, baseline)
5355
end
5456
end
5557
function judgebench(baseline::Union{String, BenchmarkConfig})

0 commit comments

Comments
 (0)