Cleanup bigint

Author: NHDaly

src/FixedPointDecimals.jl

@@ -308,17 +308,17 @@ function Base.convert(::Type{FD{T, f}}, x::Integer) where {T, f}
     end
     reinterpret(FD{T, f}, v)
 end
-function Base.convert(::Type{FD{BigT, f}}, x::Integer) where {BigT<:Union{BigFloat,BigInt}, f}
+function Base.convert(::Type{FD{BigInt, f}}, x::Integer) where {f}
     # We specialize on f==1, since julia can't eliminate BigInt multiplication.
     if f == 1
         # If x is already a BigInt, this is a no-op, otherwise we alloc a new BigInt.
-        return reinterpret(FD{BigT, f}, BigT(x))
+        return reinterpret(FD{BigInt, f}, BigInt(x))
     end
     # For the normal case, we multiply by C, which produces a BigInt value.
-    C = coefficient(FD{BigT, f})
+    C = coefficient(FD{BigInt, f})
     # This can't throw since BigInt and BigFloat can hold any number.
     v = x * C
-    reinterpret(FD{BigT, f}, v)
+    reinterpret(FD{BigInt, f}, v)
 end
 
 Base.convert(::Type{T}, x::AbstractFloat) where {T <: FD} = round(T, x)

test/FixedDecimal.jl

@@ -317,6 +317,12 @@ end
         @test convert(FixedDecimal{BigInt,2}, Int128(-1)).i == BigInt(-100)
         @test convert(FixedDecimal{BigInt,2}, typemax(UInt128)).i == BigInt(typemax(UInt128))*100
     end
+
+    @testset "Convert from Big* to BigInt" begin
+        @test convert(FixedDecimal{BigInt,2}, BigInt(1)).i == BigInt(100)
+        @test convert(FixedDecimal{BigInt,2}, BigFloat(1)).i == BigInt(100)
+        @test convert(FixedDecimal{BigInt,2}, BigFloat(1.5)).i == BigInt(150)
+    end
 end
 
 module PerfTests