Simplify Particle Swarm Options Constructor. (#43)

* simplify constructor of pso.
* bump version

Author: kellertuer

Project.toml

@@ -1,7 +1,7 @@
 name = "Manopt"
 uuid = "0fc0a36d-df90-57f3-8f93-d78a9fc72bb5"
 authors = ["Ronny Bergmann <manopt@ronnybergmann.net>"]
-version = "0.2.11"
+version = "0.2.12"
 
 [deps]
 ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"

src/plans/particle_swarm_plan.jl

@@ -49,24 +49,24 @@ mutable struct ParticleSwarmOptions{
     retraction_method::TRetraction
     inverse_retraction_method::TInvRetraction
     vector_transport_method::TVTM
-    function ParticleSwarmOptions{P}(
+    function ParticleSwarmOptions(
         x0::AbstractVector,
         velocity::AbstractVector,
-        inertia::TParams=0.65,
-        social_weight::TParams=1.4,
-        cognitive_weight::TParams=1.4,
+        inertia=0.65,
+        social_weight=1.4,
+        cognitive_weight=1.4,
         stopping_criterion::StoppingCriterion=StopWhenAny(
             StopAfterIteration(500), StopWhenChangeLess(10.0^(-4))
         ),
         retraction_method::AbstractRetractionMethod=ExponentialRetraction(),
         inverse_retraction_method::AbstractInverseRetractionMethod=LogarithmicInverseRetraction(),
         vector_transport_method::AbstractVectorTransportMethod=ParallelTransport(),
-    ) where {P,TParams}
+    )
         o = new{
             typeof(x0),
-            P,
+            eltype(x0),
             typeof(velocity),
-            TParams,
+            typeof(inertia + social_weight + cognitive_weight),
             typeof(stopping_criterion),
             typeof(retraction_method),
             typeof(inverse_retraction_method),
@@ -85,28 +85,3 @@ mutable struct ParticleSwarmOptions{
         return o
     end
 end
-function ParticleSwarmOptions(
-    x0::AbstractVector{P},
-    velocity::AbstractVector,
-    inertia::Real=0.65,
-    social_weight::Real=1.4,
-    cognitive_weight::Real=1.4,
-    stopping_criterion::StoppingCriterion=StopWhenAny(
-        StopAfterIteration(500), StopWhenChangeLess(10.0^(-4))
-    ),
-    retraction_method::AbstractRetractionMethod=ExponentialRetraction(),
-    inverse_retraction_method::AbstractInverseRetractionMethod=LogarithmicInverseRetraction(),
-    vector_transport_method::AbstractVectorTransportMethod=ParallelTransport(),
-) where {P,T}
-    return ParticleSwarmOptions{P}(
-        x0,
-        velocity,
-        inertia,
-        social_weight,
-        cognitive_weight,
-        stopping_criterion,
-        retraction_method,
-        inverse_retraction_method,
-        vector_transport_method,
-    )
-end