Update compatibility to BLIS v1.0 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update now merged on Yggdrasil. |
|
While trying to fix CI and tag a new release, I noticed that tests are (hard) failing on Windows. I'm not sure it's related to this bump but it could be. Feels bad to tag a new release that doesn't (fully) work on Windows. At least, this should be investigated a little bit further, I think. Would be great if you could help with it :) |
|
Hm, seems like it doesn't work with version 0.9 of the jll either (https://github.com/JuliaLinearAlgebra/BLISBLAS.jl/actions/runs/9282445997/job/25540486196?pr=16#step:6:100). Maybe it never fully worked on Windows? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on merging JuliaPackaging/Yggdrasil#8626 to update to BLIS v1.0.