-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Labels
invalidationslatencyLatencyLatencytestThis change adds or pertains to unit testsThis change adds or pertains to unit tests
Description
Invalidation fixes to Julia base are currently not tested. For example:
- fix invalidations from loading Static.jl #46761
- Fixed inference on String and Symbol causing invalidations in show.jl #44091
- Fix ~370 invalidations from Expr(:ncat, ...) pretty-printing #41877
This is asking for double work in the long run. Would it be possible to add something like SnoopCompileCore.@snoopr
to Julia base? This would make it easier to add a tests. For example, #46481 fixes invalidations caused by inserting:
Base.:(!)(::True) = False()
With @snoopr
defined as
the method insertion could be tested with:
@test isempty(@snoopr Base.:(!)(::True) = False())
Metadata
Metadata
Assignees
Labels
invalidationslatencyLatencyLatencytestThis change adds or pertains to unit testsThis change adds or pertains to unit tests