Merge pull request #35582 from stev47/feature/dates-pad-milli

zero-pad milliseconds for DateTime

Author: quinnj

stdlib/Dates/src/io.jl

@@ -580,9 +580,9 @@ end
 # show
 function Base.print(io::IO, dt::DateTime)
     str = if millisecond(dt) == 0
-        format(dt, dateformat"YYYY-mm-dd\THH:MM:SS", 24)
+        format(dt, dateformat"YYYY-mm-dd\THH:MM:SS", 19)
     else
-        format(dt, dateformat"YYYY-mm-dd\THH:MM:SS.s", 26)
+        format(dt, dateformat"YYYY-mm-dd\THH:MM:SS.sss", 23)
     end
     print(io, str)
 end

stdlib/Dates/test/conversions.jl

@@ -11,28 +11,28 @@ using Dates
     @test Dates.value(Dates.DateTime(1970)) == Dates.UNIXEPOCH
 
     # Tests from here: https://en.wikipedia.org/wiki/Unix_time
-    @test string(Dates.unix2datetime(1095379198.75)) == string("2004-09-16T23:59:58.75")
+    @test string(Dates.unix2datetime(1095379198.75)) == string("2004-09-16T23:59:58.750")
     @test string(Dates.unix2datetime(1095379199.00)) == string("2004-09-16T23:59:59")
-    @test string(Dates.unix2datetime(1095379199.25)) == string("2004-09-16T23:59:59.25")
-    @test string(Dates.unix2datetime(1095379199.50)) == string("2004-09-16T23:59:59.5")
-    @test string(Dates.unix2datetime(1095379199.75)) == string("2004-09-16T23:59:59.75")
+    @test string(Dates.unix2datetime(1095379199.25)) == string("2004-09-16T23:59:59.250")
+    @test string(Dates.unix2datetime(1095379199.50)) == string("2004-09-16T23:59:59.500")
+    @test string(Dates.unix2datetime(1095379199.75)) == string("2004-09-16T23:59:59.750")
     @test string(Dates.unix2datetime(1095379200.00)) == string("2004-09-17T00:00:00")
-    @test string(Dates.unix2datetime(1095379200.25)) == string("2004-09-17T00:00:00.25")
-    @test string(Dates.unix2datetime(1095379200.50)) == string("2004-09-17T00:00:00.5")
-    @test string(Dates.unix2datetime(1095379200.75)) == string("2004-09-17T00:00:00.75")
+    @test string(Dates.unix2datetime(1095379200.25)) == string("2004-09-17T00:00:00.250")
+    @test string(Dates.unix2datetime(1095379200.50)) == string("2004-09-17T00:00:00.500")
+    @test string(Dates.unix2datetime(1095379200.75)) == string("2004-09-17T00:00:00.750")
     @test string(Dates.unix2datetime(1095379201.00)) == string("2004-09-17T00:00:01")
-    @test string(Dates.unix2datetime(1095379201.25)) == string("2004-09-17T00:00:01.25")
-    @test string(Dates.unix2datetime(915148798.75)) == string("1998-12-31T23:59:58.75")
+    @test string(Dates.unix2datetime(1095379201.25)) == string("2004-09-17T00:00:01.250")
+    @test string(Dates.unix2datetime(915148798.75)) == string("1998-12-31T23:59:58.750")
     @test string(Dates.unix2datetime(915148799.00)) == string("1998-12-31T23:59:59")
-    @test string(Dates.unix2datetime(915148799.25)) == string("1998-12-31T23:59:59.25")
-    @test string(Dates.unix2datetime(915148799.50)) == string("1998-12-31T23:59:59.5")
-    @test string(Dates.unix2datetime(915148799.75)) == string("1998-12-31T23:59:59.75")
+    @test string(Dates.unix2datetime(915148799.25)) == string("1998-12-31T23:59:59.250")
+    @test string(Dates.unix2datetime(915148799.50)) == string("1998-12-31T23:59:59.500")
+    @test string(Dates.unix2datetime(915148799.75)) == string("1998-12-31T23:59:59.750")
     @test string(Dates.unix2datetime(915148800.00)) == string("1999-01-01T00:00:00")
-    @test string(Dates.unix2datetime(915148800.25)) == string("1999-01-01T00:00:00.25")
-    @test string(Dates.unix2datetime(915148800.50)) == string("1999-01-01T00:00:00.5")
-    @test string(Dates.unix2datetime(915148800.75)) == string("1999-01-01T00:00:00.75")
+    @test string(Dates.unix2datetime(915148800.25)) == string("1999-01-01T00:00:00.250")
+    @test string(Dates.unix2datetime(915148800.50)) == string("1999-01-01T00:00:00.500")
+    @test string(Dates.unix2datetime(915148800.75)) == string("1999-01-01T00:00:00.750")
     @test string(Dates.unix2datetime(915148801.00)) == string("1999-01-01T00:00:01")
-    @test string(Dates.unix2datetime(915148801.25)) == string("1999-01-01T00:00:01.25")
+    @test string(Dates.unix2datetime(915148801.25)) == string("1999-01-01T00:00:01.250")
 end
 
 @testset "conversion to/from Rata Die" begin

stdlib/Dates/test/io.jl

@@ -18,7 +18,7 @@ using Dates
     @test string(Dates.DateTime(2000, 1, 1, 0, 0, 0, 1)) == "2000-01-01T00:00:00.001"
     @test sprint(show, Dates.DateTime(2000, 1, 1, 0, 0, 0, 1)) == "Dates.DateTime(\"2000-01-01T00:00:00.001\")"
     @test string(Dates.DateTime(2000, 1, 1, 0, 0, 0, 2)) == "2000-01-01T00:00:00.002"
-    @test string(Dates.DateTime(2000, 1, 1, 0, 0, 0, 500)) == "2000-01-01T00:00:00.5"
+    @test string(Dates.DateTime(2000, 1, 1, 0, 0, 0, 500)) == "2000-01-01T00:00:00.500"
     @test string(Dates.DateTime(2000, 1, 1, 0, 0, 0, 998)) == "2000-01-01T00:00:00.998"
     @test string(Dates.DateTime(2000, 1, 1, 0, 0, 0, 999)) == "2000-01-01T00:00:00.999"
 end