Skip to content

Commit ed87ece

Browse files
JeffBezansonKristofferC
authored andcommitted
remove code forcing testsets to be compiled (#34405)
1 parent 40569c2 commit ed87ece

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

stdlib/Test/src/Test.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1101,9 +1101,6 @@ function testset_beginend(args, tests, source)
11011101
ex = quote
11021102
_check_testset($testsettype, $(QuoteNode(testsettype.args[1])))
11031103
local ts = $(testsettype)($desc; $options...)
1104-
# this empty loop is here to force the block to be compiled,
1105-
# which is needed for backtrace scrubbing to work correctly.
1106-
while false; end
11071104
push_testset(ts)
11081105
# we reproduce the logic of guardseed, but this function
11091106
# cannot be used as it changes slightly the semantic of @testset,

stdlib/Test/test/runtests.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -607,8 +607,6 @@ end
607607
end
608608
""")
609609
local msg = read(pipeline(ignorestatus(`$(Base.julia_cmd()) --startup-file=no --color=no $f`), stderr=devnull), String)
610-
# NOTE: This test depends on the code generated by @testset getting compiled,
611-
# to get good backtraces. If it fails, check the implementation of `testset_beginend`.
612610
@test !occursin("do_test(", msg)
613611
@test !occursin("include(", msg)
614612
@test occursin("at " * f * ":3", msg)

0 commit comments

Comments
 (0)